Change makeTensorFromDataId to makeTensorFromTensorInfo #6355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qjia7
force-pushed
the
makeTensorFromTensorInfo
branch
from
4d6f8e1 to
caaba2d
Compare
qjia7
changed the title
|
It seems that @pyu10055 @lina128 Please take a look if the PR is necessary. Thanks. |
pyu10055
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
Thanks I really like this refactoring!
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @lina128)
lina128
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
Thank you for the refactor!
Reviewable status:
mattsoulanille
added a commit
that referenced
this pull request
May 3, 2022
* [node] Use makeTensorFromTensorInfo instead of makeTensorFromId See #6355 * [node] Disable upperBound and lowerBound tests Co-authored-by: Na Li <linazhao@google.com>
mattsoulanille
added a commit
that referenced
this pull request
May 20, 2022
makeTensorFromDataId was removed by #6355 but it should have been deprecated instead. This PR adds it back as a deprecated function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is