Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] Use makeTensorFromTensorInfo instead of makeTensorFromId #6361

Conversation

mattsoulanille
Copy link
Member

@mattsoulanille mattsoulanille commented May 2, 2022

See #6355

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@mattsoulanille mattsoulanille requested review from lina128 and pyu10055 May 2, 2022 18:02
@mattsoulanille mattsoulanille force-pushed the make_tensor_from_tensor_info_node branch from 2703404 to 05d1a0f Compare May 2, 2022 18:13
@mattsoulanille mattsoulanille force-pushed the make_tensor_from_tensor_info_node branch from 05d1a0f to 45fa346 Compare May 2, 2022 19:52
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @lina128)

Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: :shipit: complete! 2 of 1 approvals obtained

@mattsoulanille mattsoulanille merged commit ba3a4cb into tensorflow:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants