-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebGPU] Fix shader key for ScatterProgram #7932
Conversation
Does it work to change it as below?
to
|
Nice catch! It works and just updated the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Issue
This PR fixes the following error because a TensorScatterUpdate op is trying to reuse a cached pipeline but it should not, because the size of their uniforms (the
strides
, the length of which is dynamic) are different.Solution
We could also add such uniform information into TensorScatterUpdate kernel's shader key instead of all kernel's shader key.
Alternatives considered
We could also add uniform informations into shader key to fix it, but it's unnecessary to apply it to all shader keys since this uniform problem only happens, from my perspective, for scatter program.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.