Skip to content

[WebGPU] Fix shader key for ScatterProgram #7932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 25, 2023
Merged

[WebGPU] Fix shader key for ScatterProgram #7932

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
645802f
Add uniforms
Linchenn Aug 23, 2023
58ea96f
Update webgpu_program.ts
Linchenn Aug 23, 2023
32386ac
Update webgpu_program.ts
Linchenn Aug 23, 2023
bad5fb9
Revert "Add uniforms"
Linchenn Sep 19, 2023
33d9ad4
Revert "Update webgpu_program.ts"
Linchenn Sep 19, 2023
3341e43
Revert "Update webgpu_program.ts"
Linchenn Sep 19, 2023
efa9c80
Merge branch 'master' into fixScatter
Linchenn Sep 19, 2023
6ac1472
Add key to scatter webgpu program
Linchenn Sep 19, 2023
26c4d74
Merge branch 'fixScatter' of https://github.com/Linchenn/tfjs into fi…
Linchenn Sep 19, 2023
cf9e664
Merge branch 'master' into fixScatter
pyu10055 Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tfjs-backend-webgpu/src/scatter_webgpu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,9 @@ export class ScatterProgram implements WebGPUProgram {
this.dispatch =
computeDispatch(this.dispatchLayout, flattenXShape, this.workgroupSize);
this.sliceDimGreaterThanOne = sliceDim > 1;
this.shaderKey = `scatter_${indicesRank}_${updatesRank}_${
this.sliceDimGreaterThanOne}_${outputDtype}_${sumDupeIndices}`;
this.shaderKey =
`scatter_${indicesRank}_${updatesRank}_${this.sliceDimGreaterThanOne}_${
outputDtype}_${sumDupeIndices}_${strides.length}`;
const stridesType = getCoordsDataType(strides.length);
this.uniforms =
`sliceDim : i32, strides: ${stridesType}, updatesSize: i32,`;
Expand Down