libdart: fix update to 6.13.0

[pvonmoradi]

#14617

[pvonmoradi]

FAILED: dart/CMakeFiles/dart.dir/common/PoolAllocator.cpp.o 
/home/builder/.termux-build/_cache/android-r25b-api-24-v3/bin/clang++ --target=armv7-none-linux-androideabi --gcc-toolchain=/home/builder/.termux-build/_cache/android-r25b-api-24-v3 --sysroot=/home/builder/.termux-build/_cache/android-r25b-api-24-v3/sysroot -DDART_ACTIVE_LOG_LEVEL=2 -DDART_HAVE_spdlog=1 -DFMT_HEADER_ONLY=1 -DSPDLOG_FMT_EXTERNAL -Ddart_EXPORTS -I/home/builder/.termux-build/libdart/src -I/home/builder/.termux-build/libdart/build -isystem /data/data/com.termux/files/usr/include/eigen3 -march=armv7-a -mfpu=neon -mfloat-abi=softfp -mthumb -fstack-protector-strong -Oz --target=armv7a-linux-androideabi24  -I/data/data/com.termux/files/usr/include -O3 -DNDEBUG -fPIC -Wall -Wextra -fPIC -Werror -pthread -std=gnu++17 -MD -MT dart/CMakeFiles/dart.dir/common/PoolAllocator.cpp.o -MF dart/CMakeFiles/dart.dir/common/PoolAllocator.cpp.o.d -o dart/CMakeFiles/dart.dir/common/PoolAllocator.cpp.o -c /home/builder/.termux-build/libdart/src/dart/common/PoolAllocator.cpp
/home/builder/.termux-build/libdart/src/dart/common/PoolAllocator.cpp:47:3: error: static_assert failed due to requirement '8 <= sizeof(dart::common::PoolAllocator::MemoryUnit)' "sizeof(MemoryUnit) should be equal to or greater than 8."
  static_assert(
  ^
1 error generated.

Apparently dart no longer supports 32-bit plaforms:
dartsim/dart#1671 (comment)

It's intended. DART used to support and be tested in 32-bit up to 6.8.5 (only on GCC), but not afterward. We could reconsider this if needed, but 32-bit is not currently supported. Would it be possible to disable the 32-bit build for DART in vcpkg?

The breaking commit is introduced here.

Blacklisting arm and i686...

[pvonmoradi]

@xtkoba
Any ideas on this?
ERROR: Package contains directory "$PREFIX/$PREFIX" (/data/data/com.termux/files/usr/data/data/com.termux/files/usr)

[xtkoba]

ERROR: Package contains directory "$PREFIX/$PREFIX" (/data/data/com.termux/files/usr/data/data/com.termux/files/usr)

Ah that may be unfriendly. But you can find that directory in termux_step_post_make_install to see what are in.

[xtkoba]

Hunk number 3 of CMakeLists.txt.patch contained the fix for $PREFIX/$PREFIX. Why did you delete that file entirely?

[pvonmoradi]

Why did you delete that file entirely?

I had to create the patch again since the upstream introduced a switch to disable dartpy component.
The build problem was that the "patch" had a "diff" extention so it was not applied. I can't figure this out, should git diffs have the patch extension (not diff) so termux build sees them? Also I was generating the git diff based on the wrong branch of upstream

[Grimler91]

.patch files are applied automatically, .diff is usually used when patch is applied manually in build recipe, for example because a custom variable (i.e. not one of these ones) has to be sed'ed first