Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] makefile to properly pass RocksDB build options #654

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Jan 6, 2022

Summary of change

close #653

  • fix makefile to pass RocksDB build option
  • create snapshot folder for initializing rocksdb. rocksdb does not create parent folder automatically
  • add cmd example for rocksdb build option

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Jan 6, 2022
@yun-yeo yun-yeo requested a review from hanjukim January 6, 2022 07:43
@yun-yeo yun-yeo changed the title Fix makefile to properly pass rocks db build options Fix makefile to properly pass RocksDB build options Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #654 (dffc5be) into main (5fb2f85) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #654   +/-   ##
=======================================
  Coverage   44.63%   44.63%           
=======================================
  Files         120      120           
  Lines        6999     6999           
=======================================
  Hits         3124     3124           
  Misses       3630     3630           
  Partials      245      245           

@yun-yeo yun-yeo changed the title Fix makefile to properly pass RocksDB build options [BugFix] makefile to properly pass RocksDB build options Jan 7, 2022
@yun-yeo yun-yeo added daemon daemon updates devops installation, deployment and node management enhancement New feature or request labels Jan 7, 2022
@yun-yeo yun-yeo merged commit 0c293aa into main Jan 7, 2022
@yun-yeo yun-yeo deleted the fix-makefile branch January 7, 2022 15:57
yun-yeo pushed a commit that referenced this pull request Jan 11, 2022
* Update README.md (#651)

update gentx parameter

* This paves the way for the use of rocksdb by default. (#642)

* [Feature] use custom `cosmos-sdk` and `tendermint` (#655)

* use custom cosmos-sdk to use follow features
* oracle tx mempool priority
* configurable iavl cache size
* configurable inter-block cache size

* change dependencies to tag

* [BugFix] makefile to properly pass RocksDB build options (#654)

* fix db configuration and create snapshot dir if not exist

* add example cmd to use rocksdb

* update tendermint and cosmos-sdk to performance branch which is using RWMutex for querying

Co-authored-by: Geoff Lee <geoff@terra.money>
Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
daemon daemon updates devops installation, deployment and node management enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] makefile COSMOS_BUILD_OPTIONS are not properly set
1 participant