Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RWMutex tendermint #656

Merged
merged 5 commits into from
Jan 11, 2022
Merged

RWMutex tendermint #656

merged 5 commits into from
Jan 11, 2022

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Jan 10, 2022

Summary of changes

Update performance branch to use performance branch of cosmos-sdk and tendermint
It also add rocksdb #654 and configurable IAVL and inter-block cache update #655.

This branch is supposed to use RWMutex on ABCI query.

in ~/.terra/config/app.toml

# InterBlockCacheSize set the size (the number of cache items) of interblock cache item
# Each item consumes 128 bytes, so the value should be dividend by 128
# Default cache size is 10mb.
# Ex) 100mb = 10,000,000 / 128 = 78,125
inter-block-cache-size = 78125

# IAVLCacheSize set the cache size (the number of cache items) of the iavl tree.
# Each item size consumes 128 bytes, so the value should be dividend by 128
# Default cache size is 100mb.
# Ex) 100mb = 100,000,000 / 128 = 781,250
iavl-cache-size = 781250

or can use rocksdb by building terrad with

COSMOS_BUILD_OPTIONS=rocksdb make install

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

Geoff Lee and others added 5 commits January 5, 2022 15:06
update gentx parameter
* use custom cosmos-sdk to use follow features
* oracle tx mempool priority
* configurable iavl cache size
* configurable inter-block cache size

* change dependencies to tag
* fix db configuration and create snapshot dir if not exist

* add example cmd to use rocksdb
@yun-yeo yun-yeo requested a review from hanjukim January 10, 2022 09:58
@yun-yeo yun-yeo self-assigned this Jan 10, 2022
@yun-yeo yun-yeo changed the title Rwmutex tendermint RWMutex tendermint Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (performance@3453fcc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             performance     #656   +/-   ##
==============================================
  Coverage               ?   44.63%           
==============================================
  Files                  ?      120           
  Lines                  ?     6999           
  Branches               ?        0           
==============================================
  Hits                   ?     3124           
  Misses                 ?     3630           
  Partials               ?      245           

@yun-yeo yun-yeo requested a review from Vritra4 January 11, 2022 02:39
Copy link

@Vritra4 Vritra4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yun-yeo yun-yeo merged commit c4c6670 into performance Jan 11, 2022
@yun-yeo yun-yeo deleted the rwmutex-tendermint branch January 11, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants