-
-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support weight in forward action #224
feat: Support weight in forward action #224
Conversation
…_listener_rules for multiple weighted target_group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but there is a bug in the provider (hashicorp/terraform-provider-aws#15144) and we need to come up with a workaround for it.
main.tf
Outdated
content { | ||
type = "forward" | ||
forward { | ||
dynamic target_group { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dynamic target_group { | |
dynamic "target_group" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add support for stickiness
as described here - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb_listener_rule#stickiness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, could you make sure that the example works when values in weight
change?
Currently, terraform apply
fails after changing it with this error:
│ Error: Error modifying LB Listener Rule: ValidationError: Target group stickiness duration must be between 1 and 604800 seconds
Here is a related bug - hashicorp/terraform-provider-aws#15144
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @antonbabenko. I updated my PR and added the stickiness block.
Thanks, @alexbricepalo ! v6.6.0 has been just released. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Added a 'weighted-forward' dynamic action block to use with the https_listener_rules for multiple weighted target_group
Motivation and Context
This adds a dynamic action block for a "weighted-forward" action_rule.type for the https_listener_rules . It allows us to create a listener rule like:
Fixes #211
Breaking Changes
No breaking changes
How Has This Been Tested?
examples/*
projectsI created the resources and visually verified the correct rules made it onto the load balancer.