Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow both interface and gateway S3 VPC endpoints #603

Closed
bodgit opened this issue Feb 24, 2021 · 2 comments · Fixed by #635
Closed

Allow both interface and gateway S3 VPC endpoints #603

bodgit opened this issue Feb 24, 2021 · 2 comments · Fixed by #635

Comments

@bodgit
Copy link

bodgit commented Feb 24, 2021

It's perfectly allowable to have both an interface and gateway S3 VPC endpoint configured but currently this module allows one or the other using the s3_endpoint_type parameter. #575 proposed making the existing S3 endpoint parameters solely for the gateway type and adding a new set of parameters for managing the interface type, but this was not merged.

See the AWS documentation here: https://docs.aws.amazon.com/AmazonS3/latest/userguide/privatelink-interface-endpoints.html

bodgit added a commit to aspectcapital/terraform-aws-vpc that referenced this issue Feb 24, 2021
This makes the existing S3 endpoint parameters purely for the gateway
type and adds new parameters for the S3 interface type. The existing
parameters that don't make sense for a gateway endpoint are removed as
well as the parameter for choosing the type.

The missing outputs are also added for parity with existing endpoints.

Based on the work in terraform-aws-modules#575.

Fixes terraform-aws-modules#603
@bodgit
Copy link
Author

bodgit commented Feb 24, 2021

I suspect the DynamoDB endpoint is also going to suffer the same problem.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant