feat: s3 interface endpoint #575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 2, 2021 22:08
|
Just looking through the existing PR's to see if anyone had added support for this. The S3 interface endpoint doesn't support private DNS though as I just found out. |
bodgit
added a commit
to aspectcapital/terraform-aws-vpc
that referenced
this pull request
Feb 24, 2021
This makes the existing S3 endpoint parameters purely for the gateway type and adds new parameters for the S3 interface type. The existing parameters that don't make sense for a gateway endpoint are removed as well as the parameter for choosing the type. The missing outputs are also added for parity with existing endpoints. Based on the work in terraform-aws-modules#575. Fixes terraform-aws-modules#603
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates the opportunity to create interface style S3 endpoint while it maintains backward API compatibility.
Fixing the error which was introduced in #573 and #564
Motivation and Context
In the PR #573 variable "s3_endpoint_type" was introduced. This works with default ("Gateway") value. However if you try to attach "Interface" interface style endpoint to a route table it will cause error
Used configuration
Error message
A gateway style endpoint attach itself to a route table
An interface style endpoint attach itself to subnets and needs SG to make it work