Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support public IPs #3

Closed
ocervell opened this issue Mar 26, 2019 · 2 comments · Fixed by #43
Closed

Support public IPs #3

ocervell opened this issue Mar 26, 2019 · 2 comments · Fixed by #43
Assignees
@omazin
Labels
enhancement New feature or request triaged Scoped and ready for work

Comments

@ocervell
Copy link

Does this module support public IP ? We'd need an access_config block in the VM's network_interface for this to happen.
If we want to support both, I suggest looking at the Forseti VM code as it took me a while to figure it out.
@aaron-lane aaron-lane added the enhancement New feature or request label Apr 16, 2019
@aaron-lane
Copy link
Contributor

We should indeed support the ability to choose public or private IP addresses.

@aaron-lane aaron-lane added the triaged Scoped and ready for work label Nov 18, 2019
@aaron-lane
Copy link
Contributor

This will need to be changed in:

  • instance_template
  • preemptible_and_regular_instance_templates

omazin added a commit to omazin/terraform-google-vm that referenced this issue Nov 19, 2019
@omazin
[instance_template] Support public IPs. Fix terraform-google-modules#3.
89cca39
@omazin omazin mentioned this issue Nov 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omazin omazin

Labels
enhancement New feature or request triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[instance_template] Support public IPs. omazin/terraform-google-vm
3 participants
@ocervell @aaron-lane @omazin