Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[instance_template] Support public IPs. #43

Merged
merged 6 commits into from
Nov 28, 2019
Merged

[instance_template] Support public IPs. #43

merged 6 commits into from
Nov 28, 2019

Conversation

omazin
Copy link
Contributor

@omazin omazin commented Nov 19, 2019

Fixes #3

@omazin omazin self-assigned this Nov 19, 2019
@omazin omazin requested a review from aaron-lane November 19, 2019 13:12
@omazin omazin removed the request for review from aaron-lane November 19, 2019 16:56
@omazin omazin changed the title [instance_template] Support public IPs. [In Progress][instance_template] Support public IPs. Nov 19, 2019
@aaron-lane aaron-lane added the enhancement New feature or request label Nov 20, 2019
@omazin omazin changed the title [In Progress][instance_template] Support public IPs. [instance_template] Support public IPs. Nov 27, 2019
@omazin omazin requested a review from aaron-lane November 27, 2019 13:40
@aaron-lane aaron-lane self-assigned this Nov 27, 2019
aaron-lane
aaron-lane suggested changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @omazin!

@omazin omazin requested a review from aaron-lane November 28, 2019 14:50
@aaron-lane aaron-lane merged commit dd199bc into terraform-google-modules:master Nov 28, 2019
@omazin omazin mentioned this pull request Dec 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-lane aaron-lane aaron-lane approved these changes

Assignees

@aaron-lane aaron-lane

@omazin omazin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support public IPs
2 participants
@omazin @aaron-lane