-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for EC2 Image Builder #11084
Comments
It looks like an initial set of resources could be:
|
Some nuance is required due to how components are created as there's a See boto/boto3#2224 for some more details. |
I'm taking a stab at this - first time though so will be slow going! If anyone else fancies a go, don't let me stop you - happy to work together :) There appears to be a bug in the API currently though which prevents creating BUILD components, making them all TESTs. Have logged it with them (aws/aws-sdk-go#3161) to see what happens.. |
@Dogers There are 6 resources + data sources here. You should probably start with one of them and say which one that is. |
I was/am planning to do them in this order: component, infraconfig, recipe, distrib, image, pipeline. Component is done save for tests and the bug I believe I've found. I've pushed it up here, thoughts, comments, PRs and especially (having not come from a dev background!) tests welcome :) |
Is anyone still working on this? |
Slowly :( |
@Dogers Do you need any help? It seems you created some code and now it's just sitting there. Maybe you create a PR individual resources and we can help you with the tests? |
Yeah, I'll take any help going! It's just slowed down now as sitting at this desk working all day isn't terribly conducive to sitting at the same desk and working on this in the evening :( |
It would be good to get a data source for at least It seems there are two APIs for this: |
@Dogers do you want to open a PR with what you have so far? |
Is it worth it at this stage? Was planning to once I'd got at least all the pieces to some level of functioning :) |
For those waiting for Terraform AWS to natively-support EC2 Image Builder, it may be possible to use Terraform -> CloudFormation -> EC2 Image Builder as a "temporary workaround" (https://aws.amazon.com/about-aws/whats-new/2020/05/ec2-image-builder-now-includes-support-for-aws-cloudformation/). |
@Dogers I think if you were to open a PR with what you have so far, others could come in and assist taking this across the finish line. |
I've actually created some modules to do just that. https://registry.terraform.io/modules/rhythmictech/imagebuilder-component-ansible/aws/0.3.0 |
Is this still moving forward? Happy to provide some help. |
Slowly yep - the distribution_configuration bit gets crazy deep which I'm still trying to work my way through. Have a look at the PR and feel free to grab stuff off the list :) |
Reference: #11084 Reference: #13316 Reference: #13485 Changes: ``` * **New Data Source:** `aws_imagebuilder_distribution_configuration` * **New Resource:** `aws_imagebuilder_distribution_configuration` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderDistributionConfiguration_basic (23.95s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Description (39.52s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_disappears (18.57s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution (42.99s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags (40.02s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description (39.36s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId (46.31s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups (23.66s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds (40.12s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name (39.12s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds (40.12s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns (40.75s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Tags (49.75s) --- PASS: TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn (18.52s) ``` Output from acceptance testing in AWS GovCloud (US) (failure information: #16178): ``` --- FAIL: TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns (10.88s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_basic (27.00s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Description (40.22s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_disappears (21.76s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags (42.09s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description (42.89s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId (51.80s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups (26.70s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds (41.44s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name (42.32s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds (42.42s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Tags (55.37s) --- PASS: TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn (25.62s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/13 09:11:34 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/13 09:11:34 [DEBUG] Running Sweeper (aws_imagebuilder_distribution_configuration) in region (us-west-2) 2020/11/13 09:11:37 Sweeper Tests ran successfully: - aws_imagebuilder_distribution_configuration 2020/11/13 09:11:37 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/13 09:11:37 [DEBUG] Running Sweeper (aws_imagebuilder_distribution_configuration) in region (us-east-1) 2020/11/13 09:11:39 Sweeper Tests ran successfully: - aws_imagebuilder_distribution_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 7.724s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/13 09:30:11 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/13 09:30:11 [DEBUG] Running Sweeper (aws_imagebuilder_distribution_configuration) in region (us-gov-west-1) 2020/11/13 09:30:14 Sweeper Tests ran successfully: - aws_imagebuilder_distribution_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 4.971s ```
Reference: #11084 Reference: #13485 Reference: #14347 Changes: ``` * **New Data Source:** `aws_imagebuilder_infrastructure_configuration` * **New Resource:** `aws_imagebuilder_infrastructure_configuration` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_basic (47.25s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Description (56.76s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_disappears (34.25s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName (75.52s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes (63.65s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair (63.67s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName (82.86s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix (76.12s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags (62.22s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds (76.90s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn (69.00s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId (76.21s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Tags (74.09s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure (62.45s) --- PASS: TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn (26.62s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_basic (51.08s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Description (66.77s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_disappears (44.79s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName (76.02s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes (71.91s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair (73.11s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName (88.93s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix (84.10s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags (71.55s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds (81.06s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn (69.43s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId (83.06s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Tags (87.65s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure (71.96s) --- PASS: TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn (33.51s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/13 14:24:06 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/13 14:24:06 [DEBUG] Running Sweeper (aws_imagebuilder_infrastructure_configuration) in region (us-west-2) 2020/11/13 14:24:09 Sweeper Tests ran successfully: - aws_imagebuilder_infrastructure_configuration 2020/11/13 14:24:09 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/13 14:24:09 [DEBUG] Running Sweeper (aws_imagebuilder_infrastructure_configuration) in region (us-east-1) 2020/11/13 14:24:11 Sweeper Tests ran successfully: - aws_imagebuilder_infrastructure_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 7.692s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/13 14:24:10 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/13 14:24:10 [DEBUG] Running Sweeper (aws_imagebuilder_infrastructure_configuration) in region (us-gov-west-1) 2020/11/13 14:24:12 Sweeper Tests ran successfully: - aws_imagebuilder_infrastructure_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 4.976s ```
Reference: #11084 Reference: #13485 Reference: #16169 (required for `aws_imagebuilder_component` resource implementation) Changes: ``` * **New Data Source:** `aws_imagebuilder_image_recipe` * **New Resource:** `aws_imagebuilder_image_recipe` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderImageRecipe_basic (38.20s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (35.14s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (34.64s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (33.35s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (36.82s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (35.17s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (57.27s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (35.26s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (37.01s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (35.18s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (34.55s) --- PASS: TestAccAwsImageBuilderImageRecipe_Description (34.98s) --- PASS: TestAccAwsImageBuilderImageRecipe_disappears (31.67s) --- PASS: TestAccAwsImageBuilderImageRecipe_Tags (59.07s) --- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (19.90s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsImageBuilderImageRecipe_basic (25.73s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (39.43s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (39.12s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (39.21s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (39.20s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (39.29s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (59.68s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (39.29s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (38.94s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (38.10s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (39.09s) --- PASS: TestAccAwsImageBuilderImageRecipe_Description (38.84s) --- PASS: TestAccAwsImageBuilderImageRecipe_disappears (34.09s) --- PASS: TestAccAwsImageBuilderImageRecipe_Tags (68.88s) --- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (24.71s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/16 15:31:54 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/16 15:31:54 [DEBUG] Running Sweeper (aws_imagebuilder_image_recipe) in region (us-west-2) 2020/11/16 15:31:56 Sweeper Tests ran successfully: - aws_imagebuilder_image_recipe 2020/11/16 15:31:56 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/16 15:31:56 [DEBUG] Running Sweeper (aws_imagebuilder_image_recipe) in region (us-east-1) 2020/11/16 15:31:57 Sweeper Tests ran successfully: - aws_imagebuilder_image_recipe ok github.com/terraform-providers/terraform-provider-aws/aws 6.199s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/16 15:32:04 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/16 15:32:04 [DEBUG] Running Sweeper (aws_imagebuilder_image_recipe) in region (us-gov-west-1) 2020/11/16 15:32:06 Sweeper Tests ran successfully: - aws_imagebuilder_image_recipe ok github.com/terraform-providers/terraform-provider-aws/aws 4.799s ```
* Add aws_imagebuilder_component * Add test for data_source_aws_imagebuilder_component * Add aws_imagebuilder_infrastructureconfiguration * Add aws_imagebuilder_recipe * Rename to aws_imagebuilder_infrastructure_configuration * Fix issue with infraconfig logging * Fix incorrect MaxItems on res * Fix S024 * Fix AWSR002 * Fix linting * [#11084] Fix the imagebuilder resource, add test and docs # Conflicts: # aws/provider.go * Fix incorrect import on error handling * Update to v2 SDK * Fix R004 lint issue * Remove changes to aws.erb * Add imagebuilder_distribution_configuration * Add imagebuilder_image_pipeline * fixed some lint issues and fixed terminate_instance_on_failure not being set on create * description can be updated in place * service/imagebuilder: Remove non-aws_imagebuilder_component files * New Resource: aws_imagebuilder_component Reference: #11084 Reference: #13315 Changes: ``` * **New Data Source:** `aws_imagebuilder_component` * **New Resource:** `aws_imagebuilder_component` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderComponent_basic (18.98s) --- PASS: TestAccAwsImageBuilderComponent_ChangeDescription (19.15s) --- PASS: TestAccAwsImageBuilderComponent_Description (19.29s) --- PASS: TestAccAwsImageBuilderComponent_disappears (15.10s) --- PASS: TestAccAwsImageBuilderComponent_KmsKeyId (23.58s) --- PASS: TestAccAwsImageBuilderComponent_Platform_Windows (19.22s) --- PASS: TestAccAwsImageBuilderComponent_SupportedOsVersions (19.15s) --- PASS: TestAccAwsImageBuilderComponent_Tags (42.96s) --- PASS: TestAccAwsImageBuilderComponent_Uri (35.66s) --- PASS: TestAccAwsImageBuilderComponentDataSource_Arn (18.51s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsImageBuilderComponent_basic (24.13s) --- PASS: TestAccAwsImageBuilderComponent_ChangeDescription (23.39s) --- PASS: TestAccAwsImageBuilderComponent_Description (24.43s) --- PASS: TestAccAwsImageBuilderComponent_disappears (19.28s) --- PASS: TestAccAwsImageBuilderComponent_KmsKeyId (28.49s) --- PASS: TestAccAwsImageBuilderComponent_Platform_Windows (24.54s) --- PASS: TestAccAwsImageBuilderComponent_SupportedOsVersions (24.05s) --- PASS: TestAccAwsImageBuilderComponent_Tags (53.99s) --- PASS: TestAccAwsImageBuilderComponent_Uri (40.78s) --- PASS: TestAccAwsImageBuilderComponentDataSource_Arn (24.26s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/12 16:58:32 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/12 16:58:32 [DEBUG] Running Sweeper (aws_imagebuilder_component) in region (us-west-2) 2020/11/12 16:58:45 Sweeper Tests ran successfully: - aws_imagebuilder_component 2020/11/12 16:58:45 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/12 16:58:45 [DEBUG] Running Sweeper (aws_imagebuilder_component) in region (us-east-1) 2020/11/12 16:58:46 Sweeper Tests ran successfully: - aws_imagebuilder_component ok github.com/terraform-providers/terraform-provider-aws/aws 18.223s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/12 16:59:00 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/12 16:59:00 [DEBUG] Running Sweeper (aws_imagebuilder_component) in region (us-gov-west-1) 2020/11/12 16:59:03 Sweeper Tests ran successfully: - aws_imagebuilder_component ok github.com/terraform-providers/terraform-provider-aws/aws 5.004s ``` * resource/aws_imagebuilder_component: terrafmt fixes * tests/data-source/aws_imagebuilder_component: terrafmt fix * Apply suggestions from code review Co-authored-by: Dogers <Dogers@users.noreply.github.com> Co-authored-by: Jakub Kania <jakubkania@blackcat.rocks> Co-authored-by: Bill Schneider <bill.schneider@optum.com>
* Add aws_imagebuilder_component * Add test for data_source_aws_imagebuilder_component * Add aws_imagebuilder_infrastructureconfiguration * Add aws_imagebuilder_recipe * Rename to aws_imagebuilder_infrastructure_configuration * Fix issue with infraconfig logging * Fix incorrect MaxItems on res * Fix S024 * Fix AWSR002 * Fix linting * [#11084] Fix the imagebuilder resource, add test and docs # Conflicts: # aws/provider.go * Fix incorrect import on error handling * Update to v2 SDK * Fix R004 lint issue * Remove changes to aws.erb * Add imagebuilder_distribution_configuration * Add imagebuilder_image_pipeline * fixed some lint issues and fixed terminate_instance_on_failure not being set on create * description can be updated in place * service/imagebuilder: Remove non-aws_imagebuilder_distribution_configuration files * New Resource: aws_imagebuilder_distribution_configuration Reference: #11084 Reference: #13316 Reference: #13485 Changes: ``` * **New Data Source:** `aws_imagebuilder_distribution_configuration` * **New Resource:** `aws_imagebuilder_distribution_configuration` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderDistributionConfiguration_basic (23.95s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Description (39.52s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_disappears (18.57s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution (42.99s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags (40.02s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description (39.36s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId (46.31s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups (23.66s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds (40.12s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name (39.12s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds (40.12s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns (40.75s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Tags (49.75s) --- PASS: TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn (18.52s) ``` Output from acceptance testing in AWS GovCloud (US) (failure information: #16178): ``` --- FAIL: TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns (10.88s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_basic (27.00s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Description (40.22s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_disappears (21.76s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags (42.09s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description (42.89s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId (51.80s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups (26.70s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds (41.44s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name (42.32s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds (42.42s) --- PASS: TestAccAwsImageBuilderDistributionConfiguration_Tags (55.37s) --- PASS: TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn (25.62s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/13 09:11:34 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/13 09:11:34 [DEBUG] Running Sweeper (aws_imagebuilder_distribution_configuration) in region (us-west-2) 2020/11/13 09:11:37 Sweeper Tests ran successfully: - aws_imagebuilder_distribution_configuration 2020/11/13 09:11:37 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/13 09:11:37 [DEBUG] Running Sweeper (aws_imagebuilder_distribution_configuration) in region (us-east-1) 2020/11/13 09:11:39 Sweeper Tests ran successfully: - aws_imagebuilder_distribution_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 7.724s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/13 09:30:11 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/13 09:30:11 [DEBUG] Running Sweeper (aws_imagebuilder_distribution_configuration) in region (us-gov-west-1) 2020/11/13 09:30:14 Sweeper Tests ran successfully: - aws_imagebuilder_distribution_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 4.971s ``` * docs/resource/aws_imagebuilder_distribution_configuration: Fix typo Co-authored-by: Dogers <Dogers@users.noreply.github.com> Co-authored-by: Jakub Kania <jakubkania@blackcat.rocks> Co-authored-by: Bill Schneider <bill.schneider@optum.com>
Hey @bflad thanks for the amazing work here! Any chance that an Image Pipeline resource will be available with the 3.16.0 release that you've quoted on some of the resolved issues? The Image Pipeline is the last mile of EC2 Image Builder and would be necessary to actually take advantage of these new resources. |
We are planning on cutting 3.16.0 today for launch day support of Network Firewall. I'm doubtful if I submitted the finishing touches for the Releasing with version 3.16.0 of the Terraform AWS Provider (likely today):
Releasing next week:
While I've got folks ears, thank you to @Dogers, @blckct, @wrschneider for their efforts in helping get this off the ground. 😄 |
* Add aws_imagebuilder_infrastructureconfiguration * Fix issue with infraconfig logging * [#11084] Fix the imagebuilder resource, add test and docs * New Resource: aws_imagebuilder_infrastructure_configuration Reference: #11084 Reference: #13485 Reference: #14347 Changes: ``` * **New Data Source:** `aws_imagebuilder_infrastructure_configuration` * **New Resource:** `aws_imagebuilder_infrastructure_configuration` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_basic (47.25s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Description (56.76s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_disappears (34.25s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName (75.52s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes (63.65s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair (63.67s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName (82.86s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix (76.12s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags (62.22s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds (76.90s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn (69.00s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId (76.21s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Tags (74.09s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure (62.45s) --- PASS: TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn (26.62s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_basic (51.08s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Description (66.77s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_disappears (44.79s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName (76.02s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes (71.91s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair (73.11s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName (88.93s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix (84.10s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags (71.55s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds (81.06s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn (69.43s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId (83.06s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Tags (87.65s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure (71.96s) --- PASS: TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn (33.51s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/13 14:24:06 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/13 14:24:06 [DEBUG] Running Sweeper (aws_imagebuilder_infrastructure_configuration) in region (us-west-2) 2020/11/13 14:24:09 Sweeper Tests ran successfully: - aws_imagebuilder_infrastructure_configuration 2020/11/13 14:24:09 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/13 14:24:09 [DEBUG] Running Sweeper (aws_imagebuilder_infrastructure_configuration) in region (us-east-1) 2020/11/13 14:24:11 Sweeper Tests ran successfully: - aws_imagebuilder_infrastructure_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 7.692s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/13 14:24:10 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/13 14:24:10 [DEBUG] Running Sweeper (aws_imagebuilder_infrastructure_configuration) in region (us-gov-west-1) 2020/11/13 14:24:12 Sweeper Tests ran successfully: - aws_imagebuilder_infrastructure_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 4.976s ``` Co-authored-by: Dogers <Dogers@users.noreply.github.com> Co-authored-by: Jakub Kania <jakubkania@blackcat.rocks>
Sorry I've gone silent - let me know if there's anything with testing or documentation you need help with. |
Reference: #11084 Reference: #13485 Reference: #16218 (required for `aws_imagebuilder_image_recipe` resource implementation) Changes: ``` * **New Data Source:** `aws_imagebuilder_image_pipeline` * **New Resource:** `aws_imagebuilder_image_pipeline` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderImagePipeline_basic (36.73s) --- PASS: TestAccAwsImageBuilderImagePipeline_Description (59.17s) --- PASS: TestAccAwsImageBuilderImagePipeline_disappears (28.69s) --- PASS: TestAccAwsImageBuilderImagePipeline_DistributionConfigurationArn (62.02s) --- PASS: TestAccAwsImageBuilderImagePipeline_EnhancedImageMetadataEnabled (61.63s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageRecipeArn (57.56s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_ImageTestsEnabled (61.52s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_TimeoutMinutes (61.49s) --- PASS: TestAccAwsImageBuilderImagePipeline_InfrastructureConfigurationArn (57.93s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition (61.29s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression (62.21s) --- PASS: TestAccAwsImageBuilderImagePipeline_Status (57.90s) --- PASS: TestAccAwsImageBuilderImagePipeline_Tags (73.01s) --- PASS: TestAccAwsImageBuilderImagePipelineDataSource_Arn (33.95s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsImageBuilderImagePipeline_basic (45.88s) --- PASS: TestAccAwsImageBuilderImagePipeline_Description (65.03s) --- PASS: TestAccAwsImageBuilderImagePipeline_disappears (39.74s) --- PASS: TestAccAwsImageBuilderImagePipeline_DistributionConfigurationArn (66.42s) --- PASS: TestAccAwsImageBuilderImagePipeline_EnhancedImageMetadataEnabled (63.39s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageRecipeArn (66.54s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_ImageTestsEnabled (65.08s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_TimeoutMinutes (61.28s) --- PASS: TestAccAwsImageBuilderImagePipeline_InfrastructureConfigurationArn (66.96s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition (61.44s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression (60.45s) --- PASS: TestAccAwsImageBuilderImagePipeline_Status (65.08s) --- PASS: TestAccAwsImageBuilderImagePipeline_Tags (81.64s) --- PASS: TestAccAwsImageBuilderImagePipelineDataSource_Arn (36.13s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/18 20:23:09 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/18 20:23:09 [DEBUG] Running Sweeper (aws_imagebuilder_image_pipeline) in region (us-west-2) 2020/11/18 20:23:11 Sweeper Tests ran successfully: - aws_imagebuilder_image_pipeline 2020/11/18 20:23:11 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/18 20:23:11 [DEBUG] Running Sweeper (aws_imagebuilder_image_pipeline) in region (us-east-1) 2020/11/18 20:23:11 Sweeper Tests ran successfully: - aws_imagebuilder_image_pipeline ok github.com/terraform-providers/terraform-provider-aws/aws 5.138s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/18 20:23:10 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/18 20:23:10 [DEBUG] Running Sweeper (aws_imagebuilder_image_pipeline) in region (us-gov-west-1) 2020/11/18 20:23:13 Sweeper Tests ran successfully: - aws_imagebuilder_image_pipeline ok github.com/terraform-providers/terraform-provider-aws/aws 4.805s ```
Reference: #11084 Reference: #13485 Reference: #16169 (required for `aws_imagebuilder_component` resource implementation) Changes: ``` * **New Data Source:** `aws_imagebuilder_image_recipe` * **New Resource:** `aws_imagebuilder_image_recipe` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderImageRecipe_basic (38.20s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (35.14s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (34.64s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (33.35s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (36.82s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (35.17s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (57.27s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (35.26s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (37.01s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (35.18s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (34.55s) --- PASS: TestAccAwsImageBuilderImageRecipe_Description (34.98s) --- PASS: TestAccAwsImageBuilderImageRecipe_disappears (31.67s) --- PASS: TestAccAwsImageBuilderImageRecipe_Tags (59.07s) --- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (19.90s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsImageBuilderImageRecipe_basic (25.73s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (39.43s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (39.12s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (39.21s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (39.20s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (39.29s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (59.68s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (39.29s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (38.94s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (38.10s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (39.09s) --- PASS: TestAccAwsImageBuilderImageRecipe_Description (38.84s) --- PASS: TestAccAwsImageBuilderImageRecipe_disappears (34.09s) --- PASS: TestAccAwsImageBuilderImageRecipe_Tags (68.88s) --- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (24.71s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/16 15:31:54 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/16 15:31:54 [DEBUG] Running Sweeper (aws_imagebuilder_image_recipe) in region (us-west-2) 2020/11/16 15:31:56 Sweeper Tests ran successfully: - aws_imagebuilder_image_recipe 2020/11/16 15:31:56 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/16 15:31:56 [DEBUG] Running Sweeper (aws_imagebuilder_image_recipe) in region (us-east-1) 2020/11/16 15:31:57 Sweeper Tests ran successfully: - aws_imagebuilder_image_recipe ok github.com/terraform-providers/terraform-provider-aws/aws 6.199s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/16 15:32:04 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/16 15:32:04 [DEBUG] Running Sweeper (aws_imagebuilder_image_recipe) in region (us-gov-west-1) 2020/11/16 15:32:06 Sweeper Tests ran successfully: - aws_imagebuilder_image_recipe ok github.com/terraform-providers/terraform-provider-aws/aws 4.799s ``` Co-authored-by: Dogers <Dogers@users.noreply.github.com> Co-authored-by: Jakub Kania <jakubkania@blackcat.rocks> Co-authored-by: Bill Schneider <bill.schneider@optum.com> Co-authored-by: Graham Davison <gdavison@hashicorp.com>
Reference: #11084 Reference: #13485 Reference: #16218 (required for `aws_imagebuilder_image_recipe` resource implementation) Changes: ``` * **New Data Source:** `aws_imagebuilder_image_pipeline` * **New Resource:** `aws_imagebuilder_image_pipeline` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderImagePipeline_basic (36.73s) --- PASS: TestAccAwsImageBuilderImagePipeline_Description (59.17s) --- PASS: TestAccAwsImageBuilderImagePipeline_disappears (28.69s) --- PASS: TestAccAwsImageBuilderImagePipeline_DistributionConfigurationArn (62.02s) --- PASS: TestAccAwsImageBuilderImagePipeline_EnhancedImageMetadataEnabled (61.63s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageRecipeArn (57.56s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_ImageTestsEnabled (61.52s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_TimeoutMinutes (61.49s) --- PASS: TestAccAwsImageBuilderImagePipeline_InfrastructureConfigurationArn (57.93s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition (61.29s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression (62.21s) --- PASS: TestAccAwsImageBuilderImagePipeline_Status (57.90s) --- PASS: TestAccAwsImageBuilderImagePipeline_Tags (73.01s) --- PASS: TestAccAwsImageBuilderImagePipelineDataSource_Arn (33.95s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsImageBuilderImagePipeline_basic (45.88s) --- PASS: TestAccAwsImageBuilderImagePipeline_Description (65.03s) --- PASS: TestAccAwsImageBuilderImagePipeline_disappears (39.74s) --- PASS: TestAccAwsImageBuilderImagePipeline_DistributionConfigurationArn (66.42s) --- PASS: TestAccAwsImageBuilderImagePipeline_EnhancedImageMetadataEnabled (63.39s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageRecipeArn (66.54s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_ImageTestsEnabled (65.08s) --- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_TimeoutMinutes (61.28s) --- PASS: TestAccAwsImageBuilderImagePipeline_InfrastructureConfigurationArn (66.96s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition (61.44s) --- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression (60.45s) --- PASS: TestAccAwsImageBuilderImagePipeline_Status (65.08s) --- PASS: TestAccAwsImageBuilderImagePipeline_Tags (81.64s) --- PASS: TestAccAwsImageBuilderImagePipelineDataSource_Arn (36.13s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/18 20:23:09 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/18 20:23:09 [DEBUG] Running Sweeper (aws_imagebuilder_image_pipeline) in region (us-west-2) 2020/11/18 20:23:11 Sweeper Tests ran successfully: - aws_imagebuilder_image_pipeline 2020/11/18 20:23:11 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/18 20:23:11 [DEBUG] Running Sweeper (aws_imagebuilder_image_pipeline) in region (us-east-1) 2020/11/18 20:23:11 Sweeper Tests ran successfully: - aws_imagebuilder_image_pipeline ok github.com/terraform-providers/terraform-provider-aws/aws 5.138s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/18 20:23:10 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/18 20:23:10 [DEBUG] Running Sweeper (aws_imagebuilder_image_pipeline) in region (us-gov-west-1) 2020/11/18 20:23:13 Sweeper Tests ran successfully: - aws_imagebuilder_image_pipeline ok github.com/terraform-providers/terraform-provider-aws/aws 4.805s ``` Co-authored-by: Dogers <Dogers@users.noreply.github.com> Co-authored-by: Jakub Kania <jakubkania@blackcat.rocks> Co-authored-by: Bill Schneider <bill.schneider@optum.com>
Support for new Given that these types of "support service" issues do not have a great definition of done as time progresses, we are closing this one and have created followup issues:
Please feel free to 👍 react to those if interested and subscribe to them for updates. If you have other feature requests or bug reports with this service, please create new issues. Thank you! |
This has been released in version 3.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Description
EC2 Image Builder was just announced. This issue is to track implementation (and votes) for the feature.
References
The text was updated successfully, but these errors were encountered: