Add Resource & Data Source aws_ec2_transit_gateway_peering_attachment #11162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create and read functions implemented to interact with the AWS GO SDK for transit gateway peering attachments. waitFor functions added for Create/Read terraform operations. Describe function added for transit gateway peering attachments.
Create Update/Delete/refresh functions implemented to interact with the AWS GO SDK for transit gateway peering attachments waitFor functions added for Update/Delete terraform operations. Add provider resource mapping to provider.go
ghost
added
size/XL
Work for transit_gateway_peering_attachment_accepter has now been moved into its own pr hashicorp#11185.
ghost
added
size/L
j-nix
force-pushed
the
add_transit_gw_peering
branch
from
2e5426f
to
54b21e5
Compare
ghost
added
size/L
Create and read functions implemented to interact with the AWS GO SDK for transit gateway peering attachments. waitFor functions added for Create/Read terraform operations. Describe function added for transit gateway peering attachments.
Create Update/Delete/refresh functions implemented to interact with the AWS GO SDK for transit gateway peering attachments waitFor functions added for Update/Delete terraform operations. Add provider resource mapping to provider.go
Work for transit_gateway_peering_attachment_accepter has now been moved into its own pr hashicorp#11185.
ghost
added
service/mediaconvert
|
@Omarimcblack @j-nix Let me know if you need any help with testing this or #11185. |
|
Hi @ewbankkit we have been making use of the resources for our own deployments, we have some test locally - will push up sometime Monday and if you could take a look over that would be great! |
Co-authored-by: j-nix <34035447+j-nix@users.noreply.github.com>
bflad
added
new-resource
bflad
suggested changes
Apr 17, 2020
There was a problem hiding this comment.
Hi @Omarimcblack 👋 Thank you so much for this contribution. Overall this is looking great. A few little things and we should be able to get this in quickly. Please reach out with any questions or if you do not have time to implement the items. 👍
aws/resource_aws_ec2_transit_gateway_peering_attachment_test.go
Outdated
Show resolved
Hide resolved
website/docs/d/ec2_transit_gateway_peering_attachment.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/d/ec2_transit_gateway_peering_attachment.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/ec2_transit_gateway_peering_attachment.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/ec2_transit_gateway_peering_attachment.html.markdown
Outdated
Show resolved
Hide resolved
aws/resource_aws_ec2_transit_gateway_peering_attachment_test.go
Outdated
Show resolved
Hide resolved
aws/resource_aws_ec2_transit_gateway_peering_attachment_test.go
Outdated
Show resolved
Hide resolved
bflad
added
the
waiting-response
Local/peer terminology implemented based off the current account Co-Authored-By: Brian Flad <bflad417@gmail.com>
use `owner_id` attr rather than data source for caller identity Co-Authored-By: Brian Flad <bflad417@gmail.com>
Docs amended to provide different example & fix links Co-Authored-By: Brian Flad <bflad417@gmail.com>
|
Hi @Omarimcblack / @j-nix 👋 Just checking in -- do you have plans to fix up the final review items and CI failure? Please let us know. Thanks! |
…paginator function Co-authored-by: Omarimcblack <43746683+Omarimcblack@users.noreply.github.com>
…ther than enum Co-authored-by: Omarimcblack <43746683+Omarimcblack@users.noreply.github.com>
alternate provider Since local/peer terminology has been adopted it is important to test that the correct attributes are returned from a datasource when the alternate(accepter) provider is used Co-authored-by: j-nix <34035447+j-nix@users.noreply.github.com>
Closed
3 tasks
|
@bflad is aws/aws-sdk-go#3284 a requirement for this MR or is this in queue for next review? I see the milestone v2.60.0 was added so it sounds like it's on track? |
ghost
removed
the
waiting-response
|
@jtcressy this should go out today; just need to track down why cross-account testing is failing. |
bflad
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
All set, thanks @Omarimcblack! 🚀 Will handle a small testing fix post-merge.
Output from acceptance testing:
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_basic (279.30s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_differentAccount (274.76s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_disappears (298.80s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_Tags_sameAccount (341.73s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_differentAccount (290.68s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_sameAccount (281.60s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_differentAccount (291.70s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_sameAccount (308.69s)
|
This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
Omarimcblack
added a commit
to Omarimcblack/terraform-provider-aws
that referenced
this pull request
May 1, 2020
…ng_attachment (hashicorp#11162) Output from acceptance testing: ``` --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_basic (279.30s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_differentAccount (274.76s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_disappears (298.80s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_Tags_sameAccount (341.73s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_differentAccount (290.68s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_sameAccount (281.60s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_differentAccount (291.70s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_sameAccount (308.69s) ```
Omarimcblack
added a commit
to Omarimcblack/terraform-provider-aws
that referenced
this pull request
May 1, 2020
… aws_ec2_transit_gateway_peering_attachment (hashicorp#11162) Output from acceptance testing: ``` --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_basic (279.30s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_differentAccount (274.76s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_disappears (298.80s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_Tags_sameAccount (341.73s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_differentAccount (290.68s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_sameAccount (281.60s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_differentAccount (291.70s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_sameAccount (308.69s) ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Related to #11117
Release note for CHANGELOG:
Output from acceptance