Add Datasource for COIP Pool(s) (Outpost)

[johnbarney]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12302

Release note for CHANGELOG:

Add Datasource for COIP Pool(s)

Output from acceptance testing:

$ AWS_COIP_POOL_ID=ipv4pool-coip-<snip> make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsCoipPool'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsCoipPool -timeout 120m
=== RUN   TestAccDataSourceAwsCoipPool_basic
=== PAUSE TestAccDataSourceAwsCoipPool_basic
=== RUN   TestAccDataSourceAwsCoipPools_basic
=== PAUSE TestAccDataSourceAwsCoipPools_basic
=== RUN   TestAccDataSourceAwsCoipPools_filters
=== PAUSE TestAccDataSourceAwsCoipPools_filters
=== CONT  TestAccDataSourceAwsCoipPool_basic
=== CONT  TestAccDataSourceAwsCoipPools_basic
=== CONT  TestAccDataSourceAwsCoipPools_filters
--- PASS: TestAccDataSourceAwsCoipPools_basic (50.75s)
--- PASS: TestAccDataSourceAwsCoipPool_basic (50.75s)
--- PASS: TestAccDataSourceAwsCoipPools_filters (51.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.534s

[johnbarney]

$ AWS_COIP_POOL_ID=ipv4pool-coip-040963628a75e6954 make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsCoipPool'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsCoipPool -timeout 120m
=== RUN   TestAccDataSourceAwsCoipPool_basic
=== PAUSE TestAccDataSourceAwsCoipPool_basic
=== RUN   TestAccDataSourceAwsCoipPools_basic
=== PAUSE TestAccDataSourceAwsCoipPools_basic
=== RUN   TestAccDataSourceAwsCoipPools_filters
=== PAUSE TestAccDataSourceAwsCoipPools_filters
=== CONT  TestAccDataSourceAwsCoipPool_basic
=== CONT  TestAccDataSourceAwsCoipPools_basic
=== CONT  TestAccDataSourceAwsCoipPools_filters
--- PASS: TestAccDataSourceAwsCoipPools_filters (53.27s)
--- PASS: TestAccDataSourceAwsCoipPool_basic (53.27s)
--- PASS: TestAccDataSourceAwsCoipPools_basic (53.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	55.730s

[bflad]

Hi @johnbarney 👋 Thank you for submitting this as well! Overall it was looking pretty good. Please note that we're trying to sneak these in while we have an Outpost available for testing for a limited time so pulling this in with some slight modifications in a followup commit (rather than our normal back-and-forth during review):

• Renaming everything to include the service name, EC2. aws_ec2_coip_pool, AwsEc2CoipPool, etc. We are trying to get very rigid with naming everything in the Terraform AWS Provider with aws_SERVICE_THING. This may be strictly enforced with some code and tooling work we have planned. EC2 just happens to include lots of anti-examples until we get around to aliasing/fixing the data sources and resources from the oldest versions of Terraform. 😅
• Consistently using the AWS_OUTPOST_ARN environment variable as the gatekeeper for any testing requiring an Outpost. We run our testing in a lot of different environments, so keeping it to one environment variable to skip or run this testing will make it easiest hopefully for everyone. 😄

Thanks again, this is great! Folks will really appreciate this going forward.

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsEc2CoipPool_Id (17.77s)
--- PASS: TestAccDataSourceAwsEc2CoipPool_Filter (17.85s)

--- PASS: TestAccDataSourceAwsEc2CoipPools_basic (15.76s)
--- PASS: TestAccDataSourceAwsEc2CoipPools_Filter (17.70s)

[ghost]

This has been released in version 2.61.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!