Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ip_address property to aws_mq_broker instances list #6103

Merged
merged 5 commits into from
Oct 10, 2018
Merged

Add ip_address property to aws_mq_broker instances list #6103

merged 5 commits into from
Oct 10, 2018

Conversation

chrislewisdev
Copy link
Contributor

Potential fix for #5913.

Changes proposed in this pull request:

  • Expose the IpAddress property returned by the AWS SDK for Amazon MQ Broker Instances
  • Update documentation (I noticed ActiveMQ 5.15.6 is also now supported by Amazon MQ, so I added that in too)

Output from acceptance testing:

I wasn't able to run the full set of acceptance tests for aws_mq_broker last night, but running TestAccAWSMqBroker_basic passed. I'll have another shot at running the other tests later today.

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/mq Issues and PRs that pertain to the mq service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 9, 2018
@chrislewisdev
Copy link
Contributor Author

Update with acceptance test results:

TF_ACC=1 go test ./aws -v -run=TestAccAWSMqBroker -timeout 120m
=== RUN   TestAccAWSMqBroker_basic
--- PASS: TestAccAWSMqBroker_basic (917.77s)
=== RUN   TestAccAWSMqBroker_allFieldsDefaultVpc
--- PASS: TestAccAWSMqBroker_allFieldsDefaultVpc (1978.61s)
=== RUN   TestAccAWSMqBroker_allFieldsCustomVpc
--- PASS: TestAccAWSMqBroker_allFieldsCustomVpc (1999.73s)
=== RUN   TestAccAWSMqBroker_updateUsers
--- PASS: TestAccAWSMqBroker_updateUsers (1391.64s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       6292.000s

@bflad bflad added this to the v1.40.0 milestone Oct 10, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @chrislewisdev! 🚀

--- PASS: TestAccAWSMqBroker_basic (960.52s)
--- PASS: TestAccAWSMqBroker_updateUsers (1367.97s)
--- PASS: TestAccAWSMqBroker_allFieldsDefaultVpc (1852.07s)
--- PASS: TestAccAWSMqBroker_allFieldsCustomVpc (1911.28s)

@bflad bflad merged commit fa1070f into hashicorp:master Oct 10, 2018
bflad added a commit that referenced this pull request Oct 10, 2018
@bflad
Copy link
Contributor

bflad commented Oct 10, 2018

This has been released in version 1.40.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/mq Issues and PRs that pertain to the mq service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants