Timeline: fix kWh values and column layout for miles (#3846)

[sdwalker]

Add the kWh multiplication needed for driving and parking when using miles
Use the same index value for the Range Diff column so the layout is the same with miles or kilometers

[netlify]

✅ Deploy Preview for teslamate ready!

Name	Link
🔨 Latest commit	20a2c5a
🔍 Latest deploy log	https://app.netlify.com/sites/teslamate/deploys/661deb03a2bf83000851a643
😎 Deploy Preview	https://deploy-preview-3847--teslamate.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[DrMichael]

May I propose to use convert_km instead of CASE in the SQL statement? Just to be consistent.

[sdwalker]

May I propose to use convert_km instead of CASE in the SQL statement? Just to be consistent.

convert_km divides by 1.60934 so the proper fix for charging looks to be to not use convert_km at all

-convert_km((end_[[preferred_range]]_range_km - start_[[preferred_range]]_range_km)::NUMERIC, '$length_unit') * efficiency AS "kWh",

+(end_[[preferred_range]]_range_km - start_[[preferred_range]]_range_km)::NUMERIC * efficiency AS "kWh",

Still looking at how to fix the parking query

convert_km(((LEAD(d.start_[[preferred_range]]_range_km) over w + (LEAD(d.start_km) over w - d.end_km)) - d.end_[[preferred_range]]_range_km)::NUMERIC, '$length_unit') * efficiency AS "kWh",

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions.

[JakobLichterfeld]

Still looking at how to fix the parking query

Are you planning a separate PR or include in this one?

Also please update your branch with latest master

[sdwalker]

Can we assume the parking query is correct for metric users?
If so, a metric user would be able to remove the convert_km from the parking query, switch their units and confirm the unit conversion matches

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions.

[dyxyl]

Can we assume the parking query is correct for metric users? If so, a metric user would be able to remove the convert_km from the parking query, switch their units and confirm the unit conversion matches

Yes, both the driving and parking kWh are the same in km units if the convert_km is removed so that looks like a good solution to me.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions.

[swiffer]

efficiency is stored as kwh/km, therefore convert_km seems not to be needed at all in these calculations, agree.

@dyxyl - do you want to update your PR based on latest master or should I open a follow up PR ?

[dyxyl]

I don't have a PR for this -- it was @sdwalker who originated it.

[swiffer]

😆 - sorry. @sdwalker, would you like to update the PR ?

[swiffer]

with #4367 merged this one can be closed @JakobLichterfeld