Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to associate public ip with instance #42

Closed
wants to merge 5 commits into from
Closed

add option to associate public ip with instance #42

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 30, 2014

Needed for instances running in an internet-facing subnet in order for them to be accessible without SSH forwarding.

@baumandm
Copy link

This is just what I needed, thanks!

@fnichol
Copy link
Contributor

fnichol commented Apr 12, 2014

Looking great! @tabolario think you could add a section with a few words in the README? Thanks!

@rayrod2030
Copy link

I could really use this feature in master. :)

@Jimflip
Copy link

Jimflip commented Jun 2, 2014

+1 can this get pulled in please.

@rberger
Copy link

rberger commented Jun 16, 2014

What's the status on this? Is it or #56 going to be in a release soon? VPC is now the default for AWS and not having a public IP is making it hard!

Thanks

@wday
Copy link

wday commented Jun 16, 2014

+1

1 similar comment
@mumoshu
Copy link

mumoshu commented Jul 5, 2014

👍

@ghost
Copy link
Author

ghost commented Jul 10, 2014

@fnichol Ah sorry I need to turn my GH email notifications back on for PR comments 😄 I'll get something added to the README today so this can get merged.

@ghost ghost mentioned this pull request Jul 10, 2014
@ghost
Copy link
Author

ghost commented Jul 10, 2014

I believe some more informative README docs to supplement the ones I added are coming soon to this PR courtesy of @benesch and then this should be good to go!

Additionally, this now sets associate_public_ip to true automatically if subnet_id is defined, so most of the time you won't even need to specify the option!

@benesch
Copy link
Contributor

benesch commented Jul 10, 2014

@tabolario updated and rebased my documentation on the tip of your PR. Should be ready to go!

add associate_public_ip option documentation
@ghost
Copy link
Author

ghost commented Jul 10, 2014

@benesch Thank you kindly!

@fnichol I dare say this is good to go!

@ghost
Copy link
Author

ghost commented Jul 29, 2014

Any update on this one?

@ghost
Copy link
Author

ghost commented Jul 29, 2014

Reason I ask is I presently need this functionality when using test-kitchen with Chef DK and I'd prefer to be able to use kitchen-ec2 from RubyGems instead of packaging my branch 😄

@benesch
Copy link
Contributor

benesch commented Jul 30, 2014

seconded! @sethvargo?

@schisamo
Copy link
Contributor

This has been merged! 7172ced

@schisamo schisamo closed this Aug 14, 2014
@ghost ghost deleted the feature/public_ip_address branch September 8, 2014 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants