Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add associate_public_ip option #56

Closed
wants to merge 1 commit into from
Closed

Conversation

benesch
Copy link
Contributor

@benesch benesch commented May 21, 2014

Instances launched within a VPC do not automatically receive public IP addresses. Add an associate_public_ip option to instruct Fog to allocate and assign a public IP to the launched instance.

Instances launched within a VPC do not automatically receive public IP
addresses.
@benesch
Copy link
Contributor Author

benesch commented May 22, 2014

PS: I had to adjust alignment, so this diff is cleaner if you ignore whitespace changes: https://github.com/test-kitchen/kitchen-ec2/pull/56/files?w=1

@benmcrae
Copy link

benmcrae commented Jul 8, 2014

Would be great to have this merged

@therobot
Copy link

therobot commented Jul 9, 2014

👍 to merging.

@ghost
Copy link

ghost commented Jul 10, 2014

@benmcrae Your docs are better than the ones I put in #42 😄 I did just update that PR so that the associate_public_ip option is automatically set to true if subnet_id is set. Would you like to just PR your README docs into #42?

@benesch
Copy link
Contributor Author

benesch commented Jul 10, 2014

Oh, my bad! I somehow overlooked your PR this back when I submitted this.

Yeah, I'll add a quick note about your intelligent default and send a PR
your way by EOD.

On Thursday, July 10, 2014, Tony Burns notifications@github.com wrote:

@benmcrae https://github.com/benmcrae Your docs are better than the
ones I put in #42 #42 [image:
😄] I did just update that PR so that the associate_public_ip option
is automatically set to true if subnet_id is set. Would you like to just
PR your README docs into #42
#42?


Reply to this email directly or view it on GitHub
#56 (comment)
.

@ghost
Copy link

ghost commented Jul 10, 2014

@benesch No worries! Looking forward to combining with your superior docs!

@benesch
Copy link
Contributor Author

benesch commented Jul 10, 2014

Closing in favor of #42!

@benesch benesch closed this Jul 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants