Notifications: Handle a failure without a failure message #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASaiAnudeep
reviewed
Jul 11, 2024
The message attribute of `<failure>` is optional and some tools print the message in the textContent. We shouldn't output `undefined` if it's not present. See test-results-reporter/parser#73 for the root issue
mnoorenberghe
force-pushed
the
slack_notification_undefined_error
branch
from
c01b416 to
9e1fc65
Compare
mnoorenberghe
changed the title
|
@ASaiAnudeep Is there any chance of making a release today with my two PRs? |
|
I will release it this weekend with other changes. |
|
@mnoorenberghe thank you for your contributions. Your changes are part of release v2.0.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message attribute of
<failure>is optional and some tools print the message in the textContent. We shouldn't outputundefinedif it's not present.See test-results-reporter/parser#73 for the root issue