New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proper sorting of dependabot updates when generating a module #894

Merged

mdelapenya merged 5 commits into testcontainers:main from mdelapenya:fix-modulegenerator

Mar 1, 2023

Member

mdelapenya commented Mar 1, 2023

What does this PR do?

This PR fixes the generated code for modules:

the module dir in Go module file was hardcoded to examples: now it is modules or examples, depending on the module type.
alphabetically sorts dependabot configs, which simplifies the code generation
modifies the generator to properly sort dependabot updates
fixes the go mod file, where it was prepending 'v' to version

Why is it important?

Make the code generation experience even smoother, as there is no need to manually update any file

Related issues

Discovered while tesing add couchbase module #876
Continues fix: update modules path in generator #877

mdelapenya added 4 commits

March 1, 2023 17:20


          fix: use the right dir in Go module file

8e1ba2d


          chore: sort dependabot configs

75d30e3


          fix: proper sorting of dependabot updates

e2c10f0


          fix: do not prepend 'v' to version in go mod file

f5e3216

mdelapenya requested a review from a team as a code owner

March 1, 2023 16:35

mdelapenya added the bug label

mdelapenya self-assigned this

netlify bot commented Mar 1, 2023 •

edited

Loading

✅ Deploy Preview for testcontainers-go ready!

Name	Link
🔨 Latest commit	`6bdd051`
🔍 Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/63ff80d8b652430008ff2319
😎 Deploy Preview	https://deploy-preview-894--testcontainers-go.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.


          fix: update expected string in tests

6bdd051

sonarcloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

mdelapenya merged commit e04622f into testcontainers:main

mdelapenya deleted the fix-modulegenerator branch

March 1, 2023 17:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug