fix: update modules path in generator #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Kudos, SonarCloud Quality Gate passed!
|
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Feb 27, 2023
* main: docs: add social links in the website (testcontainers#890) Update docs link for tc-node (testcontainers#878) fix: update modules path in generator (testcontainers#877)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the generated code for modules in the following places:
examples.examples.exampletypeWhy is it important?
The generated code, although valid in terms of the compiler, generates metadata that is incorrect. E.g. it's not possible to render the website because certain paths don't exist. At the same time, the GH workflow would fail because the path is also incorrect.
Related issues