feat: migrate suggestions/pretty-dom/helpers/role-helpers to ts #850
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 48cf918:
|
|
The CI is in error ( I don't understand why it wasn't in the previous PR ). The EDIT: EDIT: |
Codecov Report
@@ Coverage Diff @@
## master #850 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 951 970 +19
Branches 288 302 +14
=========================================
+ Hits 951 970 +19
Continue to review full report at Codecov.
|
| @@ -238,7 +241,7 @@ it('should not suggest by label when using by label', async () => { | |||
| ) | |||
|
|
|||
| // if a suggestion is made, this call will throw, thus failing the test. | |||
| const password = await screen.findByLabelText(/bar/i) | |||
| const password = (await screen.findByLabelText(/bar/i)) as Element | |||
There was a problem hiding this comment.
question: Why do we need this type casting?
There was a problem hiding this comment.
we don't have already converted findByLabelText so it will return an any type for now
There was a problem hiding this comment.
Could you do a
| const password = (await screen.findByLabelText(/bar/i)) as Element | |
| const password: Element = await screen.findByLabelText(/bar/i) |
so that we're still safe once we type findByLabelText?
There was a problem hiding this comment.
it will still remain a warning, maybe we can leave as is
marcosvega91
changed the title
|
@marcosvega91 If it's not too much work would you mind extracting the CI fix into a separate PR so we can merge that first? |
|
Yes, sure |
What:
Follow-up #848 and #614
I have migrated the following files:
Why:
How:
Checklist:
docs site