-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add normalizer for matching aria-label #855
fix: add normalizer for matching aria-label #855
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d8bb655:
|
The failing checks appear to be either OR
|
Hi @johnjesse, I have fixed this issue in #850. The problem is that the |
Codecov Report
@@ Coverage Diff @@
## master #855 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 945 945
Branches 290 290
=========================================
Hits 945 945
Continue to review full report at Codecov.
|
Happy new year 😄, is there anyone available to review this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
@all-contributors add @johnjesse for bug and code. |
I've put up a pull request to add @johnjesse! 🎉 |
🎉 This PR is included in version 7.29.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
fixed the label matcher - so that it passes on the normalizer when matching the aria-label, added a test too
see #854
Why:
because the normalizer wasn't being correctly passed on
How:
see - src/queries/label-text.js
Checklist:
docs site N/A
validate
script - it just seemed to error and not output anything useful so I ended up bypassing it....byLabelText
can get the label in multiple ways - and I wanted a specific test for the aria-label case - I've added a case that isn't named after a specific method