feat: add userEvent.clear #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 98.63% 98.75% +0.11%
==========================================
Files 1 1
Lines 147 160 +13
Branches 42 44 +2
==========================================
+ Hits 145 158 +13
Misses 2 2
Continue to review full report at Codecov.
|
wachunga
force-pushed
the
wachunga/clear
branch
from
12ca22c to
e73333e
Compare
|
I wrote this in a generic way to accommodate future support of a backspace key, but that's hurting the code coverage. (No way to test it because we don't expose that yet through userEvent.) Guess I'll simplify the backspace logic until we want |
We don't need full backspace handling yet, and it was hurting code coverage
|
@Gpx When you have a moment, could you review? Thanks! |
|
Thank you 🙇 |
|
🎉 This PR is included in version 10.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a useful thing that Cypress provides. I've seen it requested a few times and recently missed it myself.
This approach closely resembles how Cypress implements it: {selectall}{backspace}. Because we don't have support for special keys yet, I simulated the relevant events but used double click for select all.
If you'd like, I can update the docs too.