Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add TypeScript userEvent.clear definition #250

Merged
merged 1 commit into from
May 8, 2020
Merged

fix: Add TypeScript userEvent.clear definition #250

merged 1 commit into from
May 8, 2020

Conversation

bdh1011
Copy link
Contributor

@bdh1011 bdh1011 commented Apr 24, 2020

I found there is no userEvent.clear type definition in version 10.1.0 (#233)
I just added userEvcent.clear

@codecov
Copy link

codecov bot commented Apr 24, 2020 •
edited
Loading

Codecov Report

Merging #250 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #250   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files           1        1           
  Lines         160      160           
  Branches       44       44           
=======================================
  Hits          158      158           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc6a003...214de26. Read the comment docs.

@pleunv pleunv mentioned this pull request Apr 24, 2020
Closed
@Meemaw Meemaw mentioned this pull request May 4, 2020
Closed
calebeby
calebeby approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@calebeby calebeby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types LGTM, @Gpx Can you take a look 👀

@Meemaw
Copy link
Contributor

Meemaw commented May 8, 2020 •
edited
Loading

cc @kentcdodds could this be merged? 🙏

kentcdodds
kentcdodds approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@kentcdodds kentcdodds merged commit 7df771f into testing-library:master May 8, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @bdh1011 for code

@allcontributors allcontributors bot mentioned this pull request May 8, 2020
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @bdh1011! 🎉

@kentcdodds
Copy link
Member

@all-contributors please add @calebeby for review

@allcontributors allcontributors bot mentioned this pull request May 8, 2020
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @calebeby! 🎉

@kentcdodds
Copy link
Member

@all-contributors please add @Meemaw for review

@allcontributors allcontributors bot mentioned this pull request May 8, 2020
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @Meemaw! 🎉

@Gpx
Copy link
Member

Gpx commented May 8, 2020

🎉 This PR is included in version 10.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Gpx Gpx added the released label May 8, 2020
@Meemaw Meemaw mentioned this pull request May 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebeby calebeby calebeby approved these changes

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdh1011 @Meemaw @kentcdodds @Gpx @calebeby