Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream v2.49.0 #22

Open
wants to merge 60 commits into
base: op-erigon
Choose a base branch
from
Open

Upstream v2.49.0 #22

wants to merge 60 commits into from

Conversation

ImTei
Copy link
Member

@ImTei ImTei commented Sep 25, 2023

Upstream sync PR

erigon

ledgerwatch/erigon v2.49.0 -> testinprod-io/op-erigon dd556a8

erigon-lib

ledgerwatch/erigon-lib dde477f -> testinprod-io/erigon-lib b7b8746

erigon-interfaces

ledgerwatch/interfaces 1fb30d8 -> testinprod-io/erigon-interfaces f2e7a04

AskAlexSharov and others added 30 commits July 6, 2023 04:08
@AskAlexSharov
mdbx bug in DeleteCurrentDuplicates() workaround (ledgerwatch#1039)
aaa51ec
@Giulio2002
Engine methods moved to separate service (ledgerwatch#1035)
41ae71f
@Giulio2002
unified pending block (ledgerwatch#1041)
371e708
@AskAlexSharov
fsync: don't skip error, ability to disable in tests (ledgerwatch#1043)
797e6dd
@yperbasis
Parse EIP-4844 transactions wrapped with blobs (ledgerwatch#1037)
441634e 
Continuation of PR ledgerwatch#1034
@AskAlexSharov
crypto lib up (ledgerwatch#1044)
7764cf6
@Giulio2002
Removed engine (ledgerwatch#1045)
a85175e
@AskAlexSharov
fix nil ptr background.progress object (ledgerwatch#1048)
18f4c2a
@Giulio2002
Updated interfaces (ledgerwatch#1049)
e7661ad
@mh0lt
Added struct to hold bor sprints in numeric order (ledgerwatch#1038)
886a982 
This checking replaces the config processing for bor sprints which has
the following issues:

1. It uses string ordering for blocks which is lexical so does not
handle decimal scale when sorting numbers
2. It parses the config map every calculation - which is expensive
relative to just checking the index order

This is likely not an issue for the existing main net as the map only
has 2 entries and their sort order is coincidentally the same for both
lexical and numeric ordering. Performance is likely also a non issue
compared to the other processing during execution flow.

These changes are intended to support tx indexing where in the
snapshotting process the calc will get called at least twice for each
bor block during 1000's of iterations.
@racytech
EIP-4844: TxPool::validateTx extension to meet specs (ledgerwatch#1046)
738be55
@mh0lt
add map size setter (ledgerwatch#1050)
32df191 
Add a bound the txpool db, rather than leaving it as the default of 2TB.
This is to reduce the page file profile when running multiple nodes from
around 3.5GB per txpool instance.

The current pool map side is set to 512MB - which seems reasonable with
16MB increments
@AlexeyAkhunov
Revert "add map size setter" (ledgerwatch#1054)
1d6b5a3 
Reverts ledgerwatch#1050

It causes the error:

`EROR[07-21|21:45:02.806] [txpool] flush is local history err="table:
PoolTransaction, err: mdbx_cursor_put: MDBX_MAP_FULL: Environment
mapsize limit reached"
`
@Giulio2002
Better handling of insertion (ledgerwatch#1055)
588e1ea
@racytech
[WIP] decompress::Match (ledgerwatch#1056)
ff28c8f
@Giulio2002
Added AssembleBlockRequest (ledgerwatch#1057)
3bd3a4c
@Giulio2002
added MemDB() (ledgerwatch#1059)
0e71e9b
@yperbasis
EIP-4844: Rename "data gas" to "blob gas" (ledgerwatch#1058)
c07cefc 
See ethereum/EIPs#7354 &
ethereum/consensus-specs#3461. Prerequisite:
erigontech/interfaces#184
@Giulio2002
moreeeeee (ledgerwatch#1060)
da71e64
@Giulio2002
added NewMemoryBatchWithCustomDB (ledgerwatch#1061)
c89353e
@Giulio2002
Better status codes for execution.proto (ledgerwatch#1062)
ddfe099
@yperbasis
Bump max size of blob transactions (ledgerwatch#1063)
3a056bb
@yperbasis
Fix blob transaction panic in txpool (ledgerwatch#1065)
f33b0bc 
Fixes the following panic triggered by blob Hive tests:
```
[2c098836] panic: runtime error: index out of range [0] with length 0
[2c098836] 
[2c098836] goroutine 902 [running]:
[2c098836] github.com/ledgerwatch/erigon-lib/txpool.MainLoop.func1()
[2c098836] 	github.com/ledgerwatch/erigon-lib@v0.0.0-20230801100033-1b342f37741d/txpool/pool.go:1565 +0x100f
[2c098836] created by github.com/ledgerwatch/erigon-lib/txpool.MainLoop
[2c098836] 	github.com/ledgerwatch/erigon-lib@v0.0.0-20230801100033-1b342f37741d/txpool/pool.go:1492 +0x8c5
```
@racytech
init kzg ctx from file (trusted_setup.json) (ledgerwatch#1066)
d4f8da7
@yperbasis
OverrideShanghaiTime -> OverrideCancunTime (ledgerwatch#1067)
0a6037d
@Giulio2002
Added memory diff to memory mutation (ledgerwatch#1068)
73d985f
@Giulio2002
save (ledgerwatch#1070)
3f118db
@Giulio2002
removed missingHash (ledgerwatch#1071)
6fc9f7e
@yperbasis
interfaces: Add parent_beacon_block_root (EIP-4788) (ledgerwatch#1069)
563a681 
Pick up erigontech/interfaces#187
@AskAlexSharov
Recsplit: cancelable build (ledgerwatch#1073)
a17eaec
Giulio2002 and others added 28 commits August 11, 2023 21:07
@Giulio2002
Gnosis fields for execution.proto (ledgerwatch#1072)
1881b49
@Giulio2002
added sentinel direct (ledgerwatch#1077)
36aec4c
@AskAlexSharov
up 'x' packages versions (ledgerwatch#1076)
de16cd6
@AskAlexSharov
log file unmap/close errors (ledgerwatch#1036)
fdd3982
@AskAlexSharov
Update README.md (ledgerwatch#1079)
0f311ab
@somnathb1
Fix broadcast issue for blob transactions (ledgerwatch#1080)
f84bd53
@AlexeyAkhunov
Add BorEvents snapshot type (ledgerwatch#1051)
3aa5249 
Co-authored-by: Alex Sharp <alexsharp@Alexs-MacBook-Pro-2.local>
@AskAlexSharov
torrent lib to support go21 (ledgerwatch#1081)
ac13f43
@AskAlexSharov
metrics: prevent commit metrics duplication (ledgerwatch#1082)
ec899e4
@AskAlexSharov
move mdbx to new org (ledgerwatch#1083)
3c4b0d4
@AskAlexSharov
rename torquem-ch project
c344806
@AskAlexSharov
Torrent: add trackers list (ledgerwatch#1084)
0cdb085
@Giulio2002
Ranges in execution.proto (ledgerwatch#1087)
bae527e
@mh0lt
Added Mdbx sizing to txpool config (ledgerwatch#1086)
c2851b6 
Added 

 ```
MdbxPageSize          datasize.ByteSize
MdbxDBSizeLimit       datasize.ByteSize
MdbxGrowthStep        datasize.ByteSize
```
to allow txpool db to be configured.
@battlmonstr
ci: check source code licenses compatibility (ledgerwatch#1089)
e3850da 
When it fails, it looks like this:

https://github.com/ledgerwatch/erigon-lib/actions/runs/6014808505/job/16315357613
@AskAlexSharov
Compress: graceful shutdown support (ledgerwatch#1090)
34cb800
@battlmonstr
doc: third-party readme and license files (ledgerwatch#1091)
a019c29
@AskAlexSharov
mdbx: m1 segfault (ledgerwatch#1093)
88e9d7a
@AskAlexSharov
up linter version
21f96bf
@Giulio2002
demoted txpool logs to Debug instead of Warn (ledgerwatch#1094)
b08f183
@yperbasis
Revert most txpool errors to Warn (ledgerwatch#1095)
82448e2 
Less radical variant of PR ledgerwatch#1094
@AskAlexSharov
save
568d783
@AskAlexSharov
shutdown deadlock (ledgerwatch#1107)
dde477f
@ImTei
Merge commit 'dde477f' into upstream-v2.49.0-dde477f
173f7cf
@ImTei
Update erigon-interfaces version
806ea07
@ImTei
make gen
ac842e4
@ImTei
Fix build error
260274a
@ImTei
Update erigon-interfaces version
f27eeca
@ImTei ImTei requested a review from pcw109550 September 25, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcw109550 pcw109550 pcw109550 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ImTei @pcw109550 @AskAlexSharov @Giulio2002 @yperbasis @mh0lt @racytech @AlexeyAkhunov @somnathb1 @battlmonstr