Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add singleton logic from testium #10

Merged
merged 2 commits into from
Oct 21, 2015
Merged

Add singleton logic from testium #10

merged 2 commits into from
Oct 21, 2015

Conversation

jkrems
Copy link
Member

@jkrems jkrems commented Oct 19, 2015

  • testium-core now exposes the config via TestiumCore.getConfig()
  • Use mocha, just like testium and testum-driver-sync
  • Move to eslint consistent with testium-driver-sync
  • Moved singleton logic from testium into testium-core

See: groupon/testium#171

@jkrems jkrems mentioned this pull request Oct 19, 2015
Merged
16 tasks
This was referenced Oct 19, 2015
Merged
Merged
@ghost
Copy link

ghost commented Oct 21, 2015

:shipit:

jkrems added a commit that referenced this pull request Oct 21, 2015
@jkrems
Merge pull request #10 from testiumjs/jk-driver-factory
f143e2c 
Add singleton logic from testium
@jkrems jkrems merged commit f143e2c into master Oct 21, 2015
@jkrems
Copy link
Member Author

jkrems commented Oct 21, 2015

v1.3.0

@jkrems jkrems deleted the jk-driver-factory branch October 21, 2015 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jkrems