-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First working version #1
Conversation
@EndangeredMassa The good news: I figured out a way to make |
|
||
function uniqueFile(file) { | ||
var testPath = file; | ||
var counter = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be counter = 0
and you can remove the counter || 0
check below (i.e. counter++
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Done.
return testPath + '.png'; | ||
} | ||
|
||
function getFile(directory, title) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this method be renamed to something more specific like slugifyFile
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generateFilename
? "slug" implies dashes for me, so I feel like it's too specific.
Updated. |
I can't find the |
Oh, it was merged and deleted. That makes sense! |
Ah, sorry. Restored it for now so any builds depending on it pass. But there's also |
Straight port from
testium
. One difference: We also expose an alternate interface which is a awesome (awful?) prototype hack which allows us to side-step the previous need for usingthis
and do the following instead:The old syntax still works:
Depends on:
Part of groupon/testium#171