Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions #3008

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Bump versions #3008

merged 1 commit into from
Nov 23, 2023

Conversation

krmahadevan
Copy link
Member

@krmahadevan krmahadevan commented Nov 21, 2023

Bumping versions

Closes #2972

Copy link
Member

@juherr juherr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, clean comments where you upgraded to the latest version

versions.properties Outdated Show resolved Hide resolved
versions.properties Outdated Show resolved Hide resolved
versions.properties Outdated Show resolved Hide resolved
versions.properties Show resolved Hide resolved
@krmahadevan
Copy link
Member Author

@juherr - Please check now


version.org.xmlunit..xmlunit-assertj=2.9.0
version.org.xmlunit..xmlunit-assertj=2.9.1
## # available=2.9.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm talking about the commented version, not the dependency.


version.in.jlibs..jlibs-core=3.0.1

version.javax..javaee-api=8.0.1
## # available=8.0.1-b5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm talking about the commented version, not the dependency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juherr - They keep getting added back everytime refreshVersions gets executed.

The whole point of basically doing this exercise was because I am noticing that the publish snapshot is failing because there are uncommitted changes https://github.com/testng-team/testng/actions/runs/6941674340/job/18882998284#step:4:93

I am guessing that somehow publish is invoking refreshVersions

So can we please get this change merged so that I can figure out if that solves the problem. If not I would have to add -PallowUncommittedChanges as suggested in the error message.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for this one. I supposed -b was for beta version that is before the release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even for the other instance where in you had mentioned about removing them, i see the same behaviour. It looks like refreshVersions adds those comments back about new versions, the moment it detects them.

@krmahadevan krmahadevan merged commit d623d0c into testng-team:master Nov 23, 2023
8 of 9 checks passed
@krmahadevan krmahadevan deleted the version_upgrade branch November 23, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestNG using vulnerable jQuery-UI version in Maven dependency (CVE-2022-31160)
2 participants