Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions #3008

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Bump versions #3008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
134 changes: 61 additions & 73 deletions versions.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,87 +1,37 @@
#### Dependencies and Plugin versions with their available updates.
#### Generated by `./gradlew refreshVersions` version 0.30.1
#### Generated by `./gradlew refreshVersions` version 0.60.3
####
#### Don't manually edit or split the comments that start with four hashtags (####),
#### they will be overwritten by refreshVersions.
####
#### suppress inspection "SpellCheckingInspection" for whole file
#### suppress inspection "UnusedProperty" for whole file

plugin.com.github.vlsi.stage-vote-release=1.78

version.ch.qos.logback..logback-classic=1.2.11
## # available=1.3.0-alpha0
## # available=1.3.0-alpha1
## # available=1.3.0-alpha2
## # available=1.3.0-alpha3
## # available=1.3.0-alpha4
## # available=1.3.0-alpha5
## # available=1.3.0-alpha6
## # available=1.3.0-alpha7
## # available=1.3.0-alpha8
## # available=1.3.0-alpha9
## # available=1.3.0-alpha10
## # available=1.3.0-alpha11
## # available=1.3.0-alpha12
## # available=1.3.0-alpha13
## # available=1.3.0-alpha14
## # available=1.3.0-alpha15
## # available=1.3.0-alpha16
## # available=1.3.0-beta0
## # available=1.3.0
## # available=1.3.1
## # available=1.3.2
## # available=1.3.3
## # available=1.3.4
## # available=1.4.0
## # available=1.4.1
## # available=1.4.2
## # available=1.4.3
## # available=1.4.4

version.ch.qos.logback..logback-core=1.2.11
## # available=1.3.0-alpha0
## # available=1.3.0-alpha1
## # available=1.3.0-alpha2
## # available=1.3.0-alpha3
## # available=1.3.0-alpha4
## # available=1.3.0-alpha5
## # available=1.3.0-alpha6
## # available=1.3.0-alpha7
## # available=1.3.0-alpha8
## # available=1.3.0-alpha9
## # available=1.3.0-alpha10
## # available=1.3.0-alpha11
## # available=1.3.0-alpha12
## # available=1.3.0-alpha13
## # available=1.3.0-alpha14
## # available=1.3.0-alpha15
## # available=1.3.0-alpha16
## # available=1.3.0-beta0
## # available=1.3.0
## # available=1.3.1
## # available=1.3.2
## # available=1.3.3
## # available=1.3.4
## # available=1.4.0
## # available=1.4.1
## # available=1.4.2
## # available=1.4.3
## # available=1.4.4
plugin.com.github.vlsi.stage-vote-release=1.90

version.assertj.core=3.23.1

version.ch.qos.logback..logback-classic=1.4.11

version.ch.qos.logback..logback-core=1.4.11

version.com.beust..jcommander=1.82

version.com.github.spotbugs..spotbugs=4.7.1
## # available=4.7.2
## # available=4.7.3
version.com.github.spotbugs..spotbugs=4.8.1

version.com.google.inject..guice-bom=5.1.0
## # available=6.0.0-rc1
## # available=6.0.0-rc2
krmahadevan marked this conversation as resolved.
Show resolved Hide resolved
## # available=6.0.0
## # available=7.0.0-rc1
## # available=7.0.0

version.commons-io..commons-io=2.11.0
version.commons-io..commons-io=2.15.0

version.in.jlibs..jlibs-core=3.0.1

version.javax..javaee-api=8.0.1
## # available=8.0.1-b5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot be removed since it is being used here https://github.com/testng-team/testng/blob/master/testng-test-osgi/testng-test-osgi-build.gradle.kts#L21

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm talking about the commented version, not the dependency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juherr - They keep getting added back everytime refreshVersions gets executed.

The whole point of basically doing this exercise was because I am noticing that the publish snapshot is failing because there are uncommitted changes https://github.com/testng-team/testng/actions/runs/6941674340/job/18882998284#step:4:93

I am guessing that somehow publish is invoking refreshVersions

So can we please get this change merged so that I can figure out if that solves the problem. If not I would have to add -PallowUncommittedChanges as suggested in the error message.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for this one. I supposed -b was for beta version that is before the release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even for the other instance where in you had mentioned about removing them, i see the same behaviour. It looks like refreshVersions adds those comments back about new versions, the moment it detects them.


version.junit.junit=4.13.2

Expand All @@ -91,20 +41,39 @@ version.mockito=4.5.1
## # available=4.7.0
## # available=4.8.0
## # available=4.8.1
## # available=4.9.0
## # available=4.10.0
## # available=4.11.0
## # available=5.0.0
## # available=5.1.0
## # available=5.1.1
## # available=5.2.0
## # available=5.3.0
## # available=5.3.1
## # available=5.4.0
## # available=5.5.0
## # available=5.6.0
## # available=5.7.0

version.org.apache-extras.beanshell..bsh=2.0b6

version.org.apache.ant..ant-testutil=1.10.12
## # available=1.10.13
## # available=1.10.14

version.org.apache.ant..ant=1.10.12
## # available=1.10.13
## # available=1.10.14

version.org.apache.felix..org.apache.felix.framework=7.0.5

version.org.assertj..assertj-core=3.22.0
## # available=3.23.0
## # available=3.23.1

version.org.codehaus.groovy..groovy-all=3.0.13
## # available=3.0.14
## # available=3.0.15
## # available=3.0.16
## # available=3.0.17
## # available=3.0.18
## # available=3.0.19

version.org.gridkit.jvmtool..heaplib=0.2

Expand All @@ -117,18 +86,25 @@ version.org.jboss.shrinkwrap..shrinkwrap-impl-base=1.2.6
## # available=2.0.0-beta-1

version.org.ops4j.pax.exam..pax-exam-container-native=4.13.1
## # available=4.13.2
## # available=4.13.3
## # available=4.13.4
## # available=4.13.5

version.org.ops4j.pax.exam..pax-exam-link-mvn=4.13.5

version.org.ops4j.pax.exam..pax-exam-testng=4.13.5

version.org.ops4j.pax.url..pax-url-aether=2.6.12
## # available=2.6.13
## # available=2.6.14

version.org.webjars..jquery=3.6.1
version.org.webjars..jquery=3.7.1

version.org.xmlunit..xmlunit-assertj=2.9.0
version.org.xmlunit..xmlunit-assertj=2.9.1
## # available=2.9.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot be removed because there are tests that are using this.

Please see https://github.com/testng-team/testng/blob/master/testng-core/src/test/java/test/reports/FailedReporterTest.java#L25

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm talking about the commented version, not the dependency.


version.org.yaml..snakeyaml=2.0
version.org.yaml..snakeyaml=2.2

version.org.slf4j..slf4j-simple=1.7.36
## # available=1.8.0-alpha0
Expand All @@ -152,6 +128,12 @@ version.org.slf4j..slf4j-simple=1.7.36
## # available=2.0.1
## # available=2.0.2
## # available=2.0.3
## # available=2.0.4
## # available=2.0.5
## # available=2.0.6
## # available=2.0.7
## # available=2.0.8
## # available=2.0.9

version.org.slf4j..slf4j-api=1.7.36
## # available=1.8.0-alpha0
Expand All @@ -175,3 +157,9 @@ version.org.slf4j..slf4j-api=1.7.36
## # available=2.0.1
## # available=2.0.2
## # available=2.0.3
## # available=2.0.4
## # available=2.0.5
## # available=2.0.6
## # available=2.0.7
## # available=2.0.8
## # available=2.0.9
Loading