Skip to content

Commit

Permalink
Close #445: Delete button moved to left side of Workday Waiver Window (
Browse files Browse the repository at this point in the history
…#592)

* resolves: #445

* Removed $WorkdayWaiver.delete from translations
  • Loading branch information
jrasmith0 authored Nov 28, 2020
1 parent e203249 commit ba041aa
Show file tree
Hide file tree
Showing 18 changed files with 5 additions and 21 deletions.
1 change: 0 additions & 1 deletion locales/ca-CA/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "País:",
"date": "Data",
"day": "Dia",
"delete": "Esborrar",
"delete-waiver-message": "Estàs segur de que vols eliminar el dia lliure?",
"end-date": "Data de finalització",
"end-date-cannot-be-less": "La data de finalització no pot ser inferior a la data d'inici.",
Expand Down
1 change: 0 additions & 1 deletion locales/de-DE/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "Land:",
"date": "Datum",
"day": "Tag",
"delete": "Löschen",
"delete-waiver-message": "Sind Sie sich sicher, dass Sie den Auschluss für diesen Tag löschen möchten",
"end-date": "Enddatum",
"end-date-cannot-be-less": "Enddatum kann nicht vor dem Startdatum liegen",
Expand Down
1 change: 0 additions & 1 deletion locales/dev/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "País:",
"date": "Data",
"day": "Dia",
"delete": "Excluir",
"delete-waiver-message": "Tem certeza de que deseja excluir a entrada no dia",
"end-date": "Data final",
"end-date-cannot-be-less": "A data de término não pode ser inferior à data de início.",
Expand Down
1 change: 0 additions & 1 deletion locales/en/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "Country:",
"date": "Date",
"day": "Day",
"delete": "Delete",
"delete-waiver-message": "Are you sure you want to delete waiver on day",
"end-date": "End Date",
"end-date-cannot-be-less": "End date cannot be less than start date.",
Expand Down
1 change: 0 additions & 1 deletion locales/es/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "País:",
"date": "Fecha",
"day": "Día",
"delete": "Borrar",
"delete-waiver-message": "¿Estás seguro de que quieres eliminar el día libre?",
"end-date": "Fecha de finalización",
"end-date-cannot-be-less": "La fecha de finalización no puede ser inferior a la fecha de inicio.",
Expand Down
1 change: 0 additions & 1 deletion locales/fr-FR/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "Pays:",
"date": "Date",
"day": "Jour",
"delete": "Supprimer",
"delete-waiver-message": "Voulez-vous vraiment supprimer la dispense le jour",
"end-date": "Date de fin",
"end-date-cannot-be-less": "La date de fin ne peut pas être inférieure à la date de début.",
Expand Down
1 change: 0 additions & 1 deletion locales/hi/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "देश:",
"date": "तारीख",
"day": "दिन",
"delete": "हटाएं",
"delete-waiver-message": "क्या आप सुनिश्चित हैं कि आप दिन पर छूट हटाना चाहते हैं",
"end-date": "अंतिम तिथि",
"end-date-cannot-be-less": "अंतिम तिथि प्रारंभ तिथि से कम नहीं हो सकती।",
Expand Down
1 change: 0 additions & 1 deletion locales/id/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "Negara:",
"date": "Tanggal",
"day": "Hari",
"delete": "Hapus",
"delete-waiver-message": "Anda yakin ingin menghapus pengecualian pada hari",
"end-date": "Tanggal Akhir",
"end-date-cannot-be-less": "Tanggal akhir tidak boleh kurang dari tanggal mulai.",
Expand Down
1 change: 0 additions & 1 deletion locales/it/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "Paese:",
"date": "Data",
"day": "Giorno",
"delete": "Elimina",
"delete-waiver-message": "Sei sicuro di voler cancellare l'esclusione sul giorno",
"end-date": "Fine giornata",
"end-date-cannot-be-less": "La data di fine non può precedere la data di inizio.",
Expand Down
1 change: 0 additions & 1 deletion locales/ko/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "국가:",
"date": "날짜",
"day": "날짜",
"delete": "삭제",
"delete-waiver-message": "정말 해당 일자의 휴가를 삭제하시겠습니까:",
"end-date": "종료일",
"end-date-cannot-be-less": "종료일은 시작일보다 늦어야 합니다.",
Expand Down
1 change: 0 additions & 1 deletion locales/mr/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "देश:",
"date": "तारीख",
"day": "दिवस",
"delete": "हटवा",
"delete-waiver-message": "आपली खात्री आहे की आपण दिवसा माफी हटवू इच्छिता",
"end-date": "शेवटची तारीख",
"end-date-cannot-be-less": "समाप्ती तारीख प्रारंभ तारखेपेक्षा कमी असू शकत नाही.",
Expand Down
1 change: 0 additions & 1 deletion locales/nl/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "Land:",
"date": "Datum",
"day": "Dag",
"delete": "Verwijderen",
"delete-waiver-message": "Weet je zeker dat je de vrije dag wilt verwijderen van",
"end-date": "Einddatum",
"end-date-cannot-be-less": "De einddatum kan niet eerder zijn dan de startdatum.",
Expand Down
1 change: 0 additions & 1 deletion locales/pl/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "Państwo:",
"date": "Data",
"day": "Dzień",
"delete": "Usuń",
"delete-waiver-message": "Czy napewno chcesz usunąć zwolnienie tego dnia?",
"end-date": "Data zakończenia",
"end-date-cannot-be-less": "Data zakończenia nie może być wcześniejsza niż data rozpoczeńcia",
Expand Down
1 change: 0 additions & 1 deletion locales/pt-BR/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "País:",
"date": "Data",
"day": "Dia",
"delete": "Excluir",
"delete-waiver-message": "Tem certeza de que deseja excluir a entrada no dia",
"end-date": "Data final",
"end-date-cannot-be-less": "A data de término não pode ser inferior à data de início.",
Expand Down
1 change: 0 additions & 1 deletion locales/th-TH/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "ประเทศ:",
"date": "วันที่",
"day": "วันที่",
"delete": "ลบ",
"delete-waiver-message": "ยืนยันการลบวันหยุด",
"end-date": "วันที่สิ้นสุด",
"end-date-cannot-be-less": "วันที่สิ้นสุดต้องไม่น้อยกว่าวันที่เริ่มต้น",
Expand Down
1 change: 0 additions & 1 deletion locales/zh-TW/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@
"country": "國家:",
"date": "日期",
"day": "",
"delete": "刪除",
"delete-waiver-message": "確定刪除此日豁免嗎",
"end-date": "結束日期",
"end-date-cannot-be-less": "結束日期不能小於開始日期",
Expand Down
2 changes: 1 addition & 1 deletion src/workday-waiver.html
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,10 @@
<table id="waiver-list-table">
<thead>
<tr>
<th></th>
<th data-i18n="$WorkdayWaiver.day">Day</th>
<th data-i18n="$WorkdayWaiver.waiver-reason">Waiver Reason</th>
<th data-i18n="$WorkdayWaiver.hours-waived">Hours Waived</th>
<th data-i18n="$WorkdayWaiver.delete">Delete</th>
</tr>
</thead>
<tbody></tbody>
Expand Down
8 changes: 4 additions & 4 deletions src/workday-waiver.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ function addRowToListTable(day, reason, hours)
{
let table = $('#waiver-list-table tbody')[0],
row = table.insertRow(0),
dayCell = row.insertCell(0),
reasonCell = row.insertCell(1),
hoursCell = row.insertCell(2),
delButtonCell = row.insertCell(3);
delButtonCell = row.insertCell(0),
dayCell = row.insertCell(1),
reasonCell = row.insertCell(2),
hoursCell = row.insertCell(3);

dayCell.innerHTML = day;
reasonCell.innerHTML = reason;
Expand Down

0 comments on commit ba041aa

Please sign in to comment.