Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remove button to the left on Workday Waiver List #445

Closed
thamara opened this issue Oct 12, 2020 · 14 comments
Closed

Move remove button to the left on Workday Waiver List #445

thamara opened this issue Oct 12, 2020 · 14 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest

Comments

@thamara
Copy link
Owner

thamara commented Oct 12, 2020

Currently, the Workday Waiver List (under Workday Waiver Manager) has 4 columns, being the last one a remove button:

image

I think it would look nicer if the button was moved to the right, in a nameless column, something like this:

image

@thamara thamara added enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest labels Oct 12, 2020
@Aqsa48
Copy link

Aqsa48 commented Oct 12, 2020

Kindly assign this to me.

@thamara
Copy link
Owner Author

thamara commented Oct 12, 2020

Sure! All yours!

@silenteyesoncode
Copy link

let me know if you need someone to work
after her

@araujoarthur0
Copy link
Collaborator

To be similar to the "Add waiver" button the Month Calendar, should the icon also be displayed only when hovering a row?
Perhaps it could just be commonly grey and turn black when the mouse hovers to indicate the active row.

@virginiarcruz
Copy link
Contributor

hey @thamara has anyone working on it?
If you wanna to assign to me I can fix it as well.

@thamara
Copy link
Owner Author

thamara commented Oct 22, 2020

Hi @Aqsa48, since we haven't got any news in 10 days, I'll be reassigning the issue to someone else.
@silenteyesoncode, would you be interested in working on this?
@virginiarcruz, as someone had already shown interested in working on this, I'll prioritize this person. If we don't receive an answer by tomorrow, I'll assign the issue to you.

@thamara thamara assigned thamara and unassigned Aqsa48 Oct 22, 2020
@silenteyesoncode
Copy link

silenteyesoncode commented Oct 22, 2020

yeah i like to work on this
put the PR ASAP

@thamara thamara assigned silenteyesoncode and unassigned thamara Oct 23, 2020
@thamara
Copy link
Owner Author

thamara commented Oct 23, 2020

Thank you!

@virginiarcruz
Copy link
Contributor

@thamara
anyone working on that?
I can fix this.

@thamara
Copy link
Owner Author

thamara commented Oct 26, 2020

Hi @virginiarcruz, @silenteyesoncode is working on this, I believe.

@silenteyesoncode
Copy link

I'll put the PR by wed @thamara

@silenteyesoncode silenteyesoncode removed their assignment Nov 4, 2020
@silenteyesoncode
Copy link

I think I got problem with Node packages
@virginiarcruz try this if you want

@jrasmith0
Copy link
Contributor

@thamara

If the issue is still available I'd like to work on it

@thamara
Copy link
Owner Author

thamara commented Nov 27, 2020

@jrasmith0 , yes, it's available! You can work on it, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest
Projects
None yet
Development

No branches or pull requests

6 participants