Propagate warnings through context #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The engine does not return warnings from storage which causes problems with partial response detection in Thanos. I initially thought we had to change the interface of each operator, but @MichaHoffmann had a neat idea to propagate warnings through the context since they have no impact on flow control. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
propagate-warnings
branch
from
4f92bc6 to
d1f7098
Compare
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
2 tasks
fpetkovski
added a commit
to fpetkovski/promql-engine
that referenced
this pull request
Aug 16, 2023
This is a follow up commit to thanos-io#298 which enables propagating warnings from remote engines into the distributed query context.
fpetkovski
added a commit
to fpetkovski/promql-engine
that referenced
this pull request
Aug 16, 2023
This is a follow up commit to thanos-io#298 which enables propagating warnings from remote engines into the distributed query context.
fpetkovski
added a commit
to fpetkovski/promql-engine
that referenced
this pull request
Aug 16, 2023
This is a follow up commit to thanos-io#298 which enables propagating warnings from remote engines into the distributed query context. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
added a commit
that referenced
this pull request
Aug 16, 2023
This is a follow up commit to #298 which enables propagating warnings from remote engines into the distributed query context. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Player256
pushed a commit
to Player256/promql-engine
that referenced
this pull request
Aug 16, 2023
* Propagate warnings through context The engine does not return warnings from storage which causes problems with partial response detection in Thanos. I initially thought we had to change the interface of each operator, but @MichaHoffmann had a neat idea to propagate warnings through the context since they have no impact on flow control. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Fix lint Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Replace fmt.Errorf with errors.New Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Use custom type as key Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Player256
pushed a commit
to Player256/promql-engine
that referenced
this pull request
Aug 16, 2023
This is a follow up commit to thanos-io#298 which enables propagating warnings from remote engines into the distributed query context. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine does not return warnings from storage which causes problems with partial response detection in Thanos.
I initially thought we had to change the interface of each operator, but @MichaHoffmann had a neat idea to propagate warnings through the context since they have no impact on flow control.