Propagate warnings from remote engines #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up commit to thanos-io#298 which enables propagating warnings from remote engines into the distributed query context. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
distributed-exec-warns
branch
from
37f99a5 to
4b01e49
Compare
GiedriusS
approved these changes
Aug 16, 2023
Player256
pushed a commit
to Player256/promql-engine
that referenced
this pull request
Aug 16, 2023
This is a follow up commit to thanos-io#298 which enables propagating warnings from remote engines into the distributed query context. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up commit to #298 which enables propagating warnings from remote engines into the distributed query context.