-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--min-time interferes with pushdown on sidecar #5069
Comments
Hey, I would like to work on this issue, can I get some guidance regarding how to proceed, Thank you! |
GiedriusS
added a commit
to GiedriusS/thanos
that referenced
this issue
Feb 10, 2022
Add repro for thanos-io#5069 by querying sidecar with --min-time enabled and then checking the result equivalence. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
added a commit
to GiedriusS/thanos
that referenced
this issue
Feb 10, 2022
Add repro for thanos-io#5069 by querying sidecar with --min-time enabled and then checking the result equivalence. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
changed the title
--min-time/--max-time interferes with pushdown on sidecar
--min-time interferes with pushdown on sidecar
Feb 10, 2022
GiedriusS
added a commit
to GiedriusS/thanos
that referenced
this issue
Feb 11, 2022
Add repro for thanos-io#5069 by querying sidecar with --min-time enabled and then checking the result equivalence. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Actually, this also applies to when Sidecar uploads a block and the minimum timestamp becomes a fixed value. Sorry, this was a bit of a harder problem that we wanted to fix ourselves so I went ahead and did it: #5142. |
GiedriusS
added a commit
that referenced
this issue
Feb 11, 2022
* test: add repro for #5069 Add repro for #5069 by querying sidecar with --min-time enabled and then checking the result equivalence. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * store: add fix for --min-time with pushdown Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * store: add clarification comment Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Nicholaswang
pushed a commit
to Nicholaswang/thanos
that referenced
this issue
Mar 6, 2022
* test: add repro for thanos-io#5069 Add repro for thanos-io#5069 by querying sidecar with --min-time enabled and then checking the result equivalence. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * store: add fix for --min-time with pushdown Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * store: add clarification comment Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Nicholaswang <wzhever@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Noticed a small problem with pushdown and
--min-time
. Since those flags modify the min/max time of a query it means that the data points will fall on different timestamps. With a big enoughstep
parameter it might just happen that even the lookback delta will not be enough - the upper PromQL engine will not "see" those data points and show no data.Thus, we probably won't be able to support exact
--min-time
values because the start/end times need to be aligned to the original min/max time and thestep
parameter.This actually also applies to when Sidecar uploads a block and the minimum timestamp becomes a fixed value.
The text was updated successfully, but these errors were encountered: