sidecar: fix for --min-time with pushdown #5142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
force-pushed
the
add_test_for_mintime
branch
from
61f1b29 to
dc6c999
Compare
Add repro for thanos-io#5069 by querying sidecar with --min-time enabled and then checking the result equivalence. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
add_test_for_mintime
branch
from
dc6c999 to
a3d3dfd
Compare
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
niaurys
approved these changes
Feb 11, 2022
Nicholaswang
pushed a commit
to Nicholaswang/thanos
that referenced
this pull request
Mar 6, 2022
* test: add repro for thanos-io#5069 Add repro for thanos-io#5069 by querying sidecar with --min-time enabled and then checking the result equivalence. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * store: add fix for --min-time with pushdown Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * store: add clarification comment Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Nicholaswang <wzhever@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add repro for #5069 by querying sidecar with --min-time enabled and then
checking the result equivalence.
Fix it by aligning min time with the step.
Signed-off-by: Giedrius Statkevičius giedrius.statkevicius@vinted.com