Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the help message for --data-dir flag #2601

Merged
merged 4 commits into from
May 16, 2020
Merged

Updated the help message for --data-dir flag #2601

merged 4 commits into from
May 16, 2020

Conversation

Harshitha1234
Copy link
Contributor

store: Improve help of --data-dir flag. #2435

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Updated the help message for --data-dir flag

Verification

bwplotka
bwplotka reviewed May 13, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, nice! (: First PR! 🏅

Some suggestions:

  • Let's elaborate more in help (see my comment)
  • Let's change title of the commit and PR to something meaningful. flag-msg-update is not helpful. Feel free to see previous commits for inspiration! (:
  • Please follow up on CI failures (click red links) to see what's wrong. I think you will have 2 failures to fix 🤗

Let us know if you are blocked!

cmd/thanos/store.go Outdated Show resolved Hide resolved
@bwplotka
Copy link
Member

Wait a second.... CI should fail =D

help is not generated... 🤔 make docs should fail.... Let's look on that tomorrow.

@Harshitha1234
Copy link
Contributor Author

Wait a second.... CI should fail =D

help is not generated... 🤔 make docs should fail.... Let's look on that tomorrow.

I'm sorry but I don't understand can you please elaborate more about generating help :)

Thanks!

@Harshitha1234 Harshitha1234 changed the title flag-msg-update Update the help message for --data-dir flag May 14, 2020
@Harshitha1234 Harshitha1234 changed the title Update the help message for --data-dir flag Updated the help message for --data-dir flag May 14, 2020
@bwplotka
Copy link
Member

Can you rebase? You will see what I have in mind (:

#2604

@Harshitha1234 Harshitha1234 force-pushed the Harshitha1234-patch-1 branch from 1454bf6 to 5fc788b Compare May 14, 2020 19:57
@Harshitha1234
Copy link
Contributor Author

Is this in someway related to #2606?

@bwplotka
Copy link
Member

what related to what? (: Let's speak offline on slack #thanos-dev or something (:

@bwplotka
Copy link
Member

hmmm somehow it's not required you to update anything ):

@bwplotka
Copy link
Member

can you ensure you have commit #2604 if you do git log or something?

@Harshitha1234 Harshitha1234 force-pushed the Harshitha1234-patch-1 branch from 5fc788b to cb1cf4f Compare May 15, 2020 08:35
@daixiang0
Copy link
Member

@Harshitha1234 hi, have you run make docs? It would generate docs with latest codes.

Harshitha1234 and others added 4 commits May 15, 2020 20:50
@Harshitha1234
Update store.go
87606e4 
Signed-off-by: Harshitha Chowdary <harshithachowdary.t17@iiits.in>
@Harshitha1234
Update store.go
75de370 
Signed-off-by: Harshitha Chowdary <harshithachowdary.t17@iiits.in>
@Harshitha1234 @bwplotka
Update cmd/thanos/store.go
b3aacfd 
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Harshitha Chowdary <harshithachowdary.t17@iiits.in>
@Harshitha1234
Updated the docs folder
e689125 
Signed-off-by: Harshitha Chowdary <harshithachowdary.t17@iiits.in>
@Harshitha1234 Harshitha1234 force-pushed the Harshitha1234-patch-1 branch from cb1cf4f to e689125 Compare May 15, 2020 15:23
@Harshitha1234
Copy link
Contributor Author

@Harshitha1234 hi, have you run make docs? It would generate docs with latest codes.

Hey @daixiang0, thanks for pointing that out :)

bwplotka
bwplotka approved these changes May 16, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bwplotka
Copy link
Member

Thanks! 💪

@bwplotka bwplotka merged commit a3e8b02 into thanos-io:master May 16, 2020
@Harshitha1234 Harshitha1234 deleted the Harshitha1234-patch-1 branch July 14, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Harshitha1234 @bwplotka @daixiang0