Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup flags for compact component #2604

Merged
merged 1 commit into from
May 18, 2020
Merged

Cleanup flags for compact component #2604

merged 1 commit into from
May 18, 2020

Conversation

philipgough
Copy link
Contributor

@philipgough philipgough commented May 14, 2020 •
edited
Loading

Introduce config structs for sidecar component.

  • Change is not relevant to the end user.

Changes

As per #2248 - this change parses flags into structs before passing into the compact run func

@philipgough philipgough marked this pull request as ready for review May 14, 2020 08:22
@bwplotka
Copy link
Member

bwplotka commented May 14, 2020 •
edited
Loading

Can you rebase? The fix will ensure we don't broke the help / flags

@bwplotka bwplotka mentioned this pull request May 14, 2020
Merged
2 tasks
@philipgough
Cleanup flags for compact component
66b7ca3 
Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
@philipgough
Copy link
Contributor Author

@bwplotka done

bwplotka
bwplotka approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💪
Hard tedious, work, so good to see effects!

@bwplotka bwplotka merged commit 762eb5e into thanos-io:master May 18, 2020
@kakkoyun
Copy link
Member

@philipgough Nice 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipgough @bwplotka @kakkoyun