Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more metadata to Series tracing; Improved tracing docs, tests; Added example. #4619

Merged
merged 3 commits into from
Sep 1, 2021

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Sep 1, 2021

Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com

@bwplotka
Copy link
Member Author

bwplotka commented Sep 1, 2021

Somehow stats for series on block-level has to be fixed:
image

Works on proxy level:

image

And on Prometheus level:

image

@bwplotka bwplotka force-pushed the tracing-test branch 2 times, most recently from 4acc744 to ad33670 Compare September 1, 2021 11:43
@bwplotka
Copy link
Member Author

bwplotka commented Sep 1, 2021

Works now:

image

…Added example.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
GiedriusS
GiedriusS previously approved these changes Sep 1, 2021
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit on grammar but otherwise LGTM

docs/tracing.md Outdated Show resolved Hide resolved
Co-authored-by: Giedrius Statkevičius <giedriuswork@gmail.com>
onprem
onprem previously approved these changes Sep 1, 2021
Copy link
Member

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just a small non-blocking nit.

docs/tracing.md Outdated Show resolved Hide resolved
Co-authored-by: Prem Kumar <prmsrswt@gmail.com>
@bwplotka bwplotka merged commit 8184ba2 into main Sep 1, 2021
@bwplotka bwplotka deleted the tracing-test branch September 1, 2021 15:01
someshkoli pushed a commit to someshkoli/thanos that referenced this pull request Nov 7, 2021
…Added example. (thanos-io#4619)

* Added more metadata to Series tracing; Improved tracing docs, tests; Added example.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

* Update docs/tracing.md

Co-authored-by: Giedrius Statkevičius <giedriuswork@gmail.com>

* Update docs/tracing.md

Co-authored-by: Prem Kumar <prmsrswt@gmail.com>

Co-authored-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Co-authored-by: Prem Kumar <prmsrswt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants