Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release 0.23 to main #5017

Merged
merged 13 commits into from
Dec 31, 2021
Merged

Conversation

squat
Copy link
Member

@squat squat commented Dec 31, 2021

This commit follows our release process and merges the latest commits/tags from the release-0.23 branch back into main. Next will be merging the release-0.24 branch back into main.

cc @GiedriusS

bwplotka and others added 12 commits September 8, 2021 12:10
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
…os-io#4684)

* Sidecar: Fix process external label on promethues v2.28+ use units.Bytes config type (thanos-io#4657)

* Sidecar: Fix process external label when promethues v2.28+ use units.Bytes config type (thanos-io#4656)

Signed-off-by: hanjm <hanjinming@outlook.com>

* E2E: Upgrade prometheus image version

Signed-off-by: hanjm <hanjinming@outlook.com>

* upgrade Prometheus dependency version to v2.30.0 (thanos-io#4669)

* upgrade Prometheus dependency version to v2.30.0

Signed-off-by: Ben Ye <ben.ye@bytedance.com>

* fix unit test

Signed-off-by: Ben Ye <ben.ye@bytedance.com>
# Conflicts:
#	go.mod
#	go.sum

* Query: Fix (*exemplarsStream).receive/(*metricMetadataStream).receive/(*targetsStreamStream).receive infinite loop when target response Unimplemented error (thanos-io#4676) (thanos-io#4681)

Signed-off-by: hanjm <hanjinming@outlook.com>

* Cut 0.23.0-rc.1

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

Co-authored-by: Jimmiehan <hanjinming@outlook.com>
Co-authored-by: Ben Ye <yb532204897@gmail.com>
…nos-io#4714)

* Do not use info client to obtain metadata

Signed-off-by: Matej Gera <matejgera@gmail.com>

* Update CHANGELOG.

Signed-off-by: Matej Gera <matejgera@gmail.com>

* Comment out client.info usage

Signed-off-by: Matej Gera <matejgera@gmail.com>

* Fix lint error

Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Avoid RLock()ing twice as described here:
thanos-io#4766 (comment)
(due to
https://stackoverflow.com/questions/30547916/goroutine-blocks-when-calling-rwmutex-rlock-twice-after-an-rwmutex-unlock/30549188).
Fix it by removing HasClients() and simply changing it with `er.clients != nil`.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Signed-off-by: Aymeric <aymeric.daurelle@cdiscount.com>

Co-authored-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
* downsample: fix deadlock if error occurs (thanos-io#4962)

Fix deadlock that occurs if there is some backlog of blocks to be
deduplicated, and an error occurs. For this to trigger, there needs to
be at least `downsampleConcurrency + 2` blocks in the backlog.

Add test to cover this regression. Affected versions 0.22.0 - 0.23.1.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* VERSION: bump

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* Makefile: update SHA256

Update from
https://github.com/thanos-io/thanos/blob/main/Makefile#L16-L17.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* *: 0.23.2 -> 0.23.2-rc.1

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Release 0.23.2.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
@squat squat requested a review from a team December 31, 2021 10:48
@squat squat force-pushed the merge-release-0.23-to-main branch 2 times, most recently from a96a6e8 to b0d054f Compare December 31, 2021 10:50
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCO missing? Also, don't forget to use a "merge" commit so that tags would end up on the main branch

@squat
Copy link
Member Author

squat commented Dec 31, 2021

It's weird.. DCO is complaining about a lot of the previous commits in there, including some of yours :( https://github.com/thanos-io/thanos/pull/5017/checks?check_run_id=4673473289

It seems to be complaining that people changed their email addresses, e.g. @vinted.com vs @gmail.com

@GiedriusS
Copy link
Member

Weird :/ since all commits have Signed-off-by, maybe we can just click "Set DCO to pass"? What's interesting is that I have my old emails on my GitHub profile but for some reason the check expects the other e-mail

@GiedriusS
Copy link
Member

Clicked "Set DCO to pass".

@squat squat merged commit 1448e12 into thanos-io:main Dec 31, 2021
@squat squat deleted the merge-release-0.23-to-main branch December 31, 2021 12:36
@matej-g matej-g mentioned this pull request Mar 17, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants