Update prometheus to 0.42.0 #6119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
update-prometheus-42
branch
from
a277721
to
9ef9a9e
Compare
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
update-prometheus-42
branch
from
341524a
to
217f5d0
Compare
fpetkovski
force-pushed
the
update-prometheus-42
branch
from
7026a17
to
3c704dc
Compare
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
update-prometheus-42
branch
from
e8bd049
to
d44ce1a
Compare
matej-g
previously approved these changes
Feb 13, 2023
pkg/query/iter.go
Outdated
| @@ -159,7 +159,7 @@ func (s *chunkSeries) Labels() labels.Labels { | |||
| return s.lset | |||
| } | |||
|
|
|||
| func (s *chunkSeries) Iterator() chunkenc.Iterator { | |||
| func (s *chunkSeries) Iterator(iterator chunkenc.Iterator) chunkenc.Iterator { | |||
There was a problem hiding this comment.
Nit: since we're not reusing the iterators, I'd either use unnamed parameter everywhere or preferably _ chunkenc.Iterator to indicate it is unused
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
update-prometheus-42
branch
from
bd23899
to
ad69820
Compare
matej-g
approved these changes
Feb 14, 2023
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
* Update prometheus to 0.42.0 Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Change type in e2e tests Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Fix lint Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Do not reuse any chunk iterators Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Make chunkenc.Iterator an unnamed parameter Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
* Update prometheus to 0.42.0 Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Change type in e2e tests Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Fix lint Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Do not reuse any chunk iterators Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Make chunkenc.Iterator an unnamed parameter Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the Prometheus dependency to 0.42.0.
There are (yet again) three breaking changes which require updates in many places:
chunkenc.Iteratorinterface now allows object reuse by passing an existing iterator instance.ScratchBuilderinterface for mutations.relabel.Processfunction now returns a secondkeepargument.Signed-off-by: Filip Petkovski filip.petkovsky@gmail.com
Changes
Verification