Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut Release 0.33.0-rc.0 #6857

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Cut Release 0.33.0-rc.0 #6857

merged 2 commits into from
Nov 7, 2023

Conversation

MichaHoffmann
Copy link
Contributor

No description provided.

@MichaHoffmann MichaHoffmann force-pushed the mhoffm-release-0.33 branch 2 times, most recently from 473d154 to 8e3eb58 Compare October 27, 2023 17:24
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 27, 2023
squat
squat approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm, however I'd like a second set of eyes from someone with more background in these dashboards to take a look too.

@sylr
Copy link
Contributor

sylr commented Oct 28, 2023

Could we wait for #6782 and #6860 ?

@MichaHoffmann
Copy link
Contributor Author

Could we wait for #6782 and #6860 ?

I would propose that we dont wait but release next minor version pretty soon! I would like to have more frequent and smaller releases perspectively.

@sylr
Copy link
Contributor

sylr commented Oct 29, 2023

That works too 👍

@MichaHoffmann
*: mark as 0.33-rc.0
82fb24d 
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
saswatamcode
saswatamcode approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, generally LGTM, we might want to cherry-pick #6864

@yeya24
Copy link
Contributor

yeya24 commented Nov 3, 2023

Do we want to get #6864 merged first?

@pull-request-size pull-request-size bot added size/M and removed size/XS labels Nov 4, 2023
@MichaHoffmann
Copy link
Contributor Author

Do we want to get #6864 merged first?

Done, cherry picked the commit on this PR

@danielmellado @MichaHoffmann
Bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp fr…
5f9540a 
…om (thanos-io#6863)

0.42.0 to 0.44.0

Signed-off-by: Daniel Mellado <dmellado@redhat.com>
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
@pull-request-size pull-request-size bot added size/XS and removed size/M labels Nov 6, 2023
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Nov 7, 2023
matej-g
matej-g approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @MichaHoffmann 🙇

squat
squat approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@squat squat merged commit 6a62cbe into thanos-io:release-0.33 Nov 7, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbaungard jacobbaungard jacobbaungard left review comments

@squat squat squat approved these changes

@yeya24 yeya24 yeya24 approved these changes

@matej-g matej-g matej-g approved these changes

@saswatamcode saswatamcode saswatamcode approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@MichaHoffmann @sylr @yeya24 @jacobbaungard @squat @matej-g @saswatamcode @danielmellado