Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor pathPrefix in all api calls #6860

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Oct 28, 2023

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Updated web ui to honor path prefix in API calls.

Verification

Pushed it to my env.

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@saswatamcode saswatamcode enabled auto-merge (squash) October 30, 2023 03:30
@saswatamcode saswatamcode merged commit 326c146 into thanos-io:main Oct 30, 2023
16 checks passed
rabenhorst pushed a commit to rabenhorst/thanos that referenced this pull request Nov 15, 2023
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
douglascamata pushed a commit to douglascamata/thanos that referenced this pull request Dec 13, 2023
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
douglascamata pushed a commit to douglascamata/thanos that referenced this pull request Dec 13, 2023
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants