Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runestone editor integration (experimental) #169 #1055

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

bummoblizard
Copy link
Member

This PR adds the option to enable Runestone editor, an iOS native editor alternative to Monaco Editor.

@bummoblizard
Copy link
Member Author

bummoblizard commented Apr 3, 2024

Right now it is not a replacement for Monaco as it is lacking many features our app relies on. Questions to ask:

  • Is it ideal to offer two editor variances? Would it be too confusing for users?
  • Can we make the experience transiting between two editors more seamless? Like falling back to Monaco where features like diff and git gutter is needed, or automatically switching to Monaco when a physical keyboard is detected.
  • Alternatively, would it be feasible to replace Monaco completely?

@bummoblizard bummoblizard merged commit fcbe8b1 into thebaselab:main Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant