Tests for #410 #482
Merged
Tests for #410 #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
=========================================
Coverage 96.33% 96.33%
Complexity 1638 1638
=========================================
Files 146 146
Lines 4115 4115
=========================================
Hits 3964 3964
Misses 151 151 Continue to review full report at Codecov.
|
|
@oojacoboo Hahaha. Okay, so after rabasing I can see that problem seems to be fixed in master already. So this PR probably only adds tests. But it would still be perfect if we could merge it and tag it, so I can require it in my project with a stable tag, rather than on master. Thanks. |
|
@ozahorulia great. We're waiting on #466 to get wrapped up before tagging a new release. It's basically done. |
Closed
andrew-demb
pushed a commit
to andrew-demb/graphqlite
that referenced
this pull request
Jun 14, 2022
* feat: add test for thecodingmachine#410 * Tests for thecodingmachine#411 (fixes thecodingmachine#410, thecodingmachine#481) Co-authored-by: Marcin Hubert <marcin.hubert@zety.com> Co-authored-by: ozahorulia <ozahorulia@unisender.com>
andrew-demb
pushed a commit
to andrew-demb/graphqlite
that referenced
this pull request
Jun 14, 2022
* feat: add test for thecodingmachine#410 * Tests for thecodingmachine#411 (fixes thecodingmachine#410, thecodingmachine#481) Co-authored-by: Marcin Hubert <marcin.hubert@zety.com> Co-authored-by: ozahorulia <ozahorulia@unisender.com>
andrew-demb
pushed a commit
to andrew-demb/graphqlite
that referenced
this pull request
Jun 14, 2022
* feat: add test for thecodingmachine#410 * Tests for thecodingmachine#411 (fixes thecodingmachine#410, thecodingmachine#481) Co-authored-by: Marcin Hubert <marcin.hubert@zety.com> Co-authored-by: ozahorulia <ozahorulia@unisender.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for #411 PR (fixes #410 and #481).