Derive $pulp_master variable #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need a corresponding installer migration to remove it ehh? |
|
Correct. It won't break the installer, but it's useless garbage to keep around in the answers file. |
This was referenced Nov 22, 2019
Closed
The Apache certs are also needed by pulp::crane. The relevant refreshes are already in foreman_proxy_content::reverse_proxy so don't need to be duplicated. $pulp is already part of the definition of $reverse_proxy_real.
We can know whether we're a pulp master depending on the proxy setting. There's no need to duplicate it.
ekohl
force-pushed
the
drop-pulp_master
branch
from
88bf015 to
9fc3131
Compare
|
Updated to ensure the correct resources are included at the right time. That was probably already an issue before, but didn't surface due to limited testing. theforeman/foreman-installer#410 should be the installer side. |
ehelms
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can know whether we're a pulp master depending on the proxy setting. There's no need to duplicate it.