Rewrite Pulp handling #218
Conversation
We can know whether we're a pulp master depending on the proxy setting. There's no need to duplicate it.
This also includes all management that puppet-katello did in the past.
manifests/pulp.pp
Outdated
| messaging_transport => 'qpid', | ||
| messaging_url => $messaging_url, | ||
| num_workers => $foreman_proxy_content::pulp_num_workers, | ||
| proxy_password => $foreman_proxy_content::pulp_proxy_password, # TODO: not in katello |
There was a problem hiding this comment.
@jlsherrill I recall you said Katello starts to configure Pulp 2 resources with explicit proxies rather than a server wide default. Does that mean we can drop proxy configs?
Note that previously only the Pulp 2 node had proxies configured where the Pulp 2 master had none. Does a node ever pull something from the internet? My impression was that they only mirror the Pulp 2 master.
Does that imply this drops the Pulp handling in puppet-katello or am I reading past the idea? |
No, that's exactly the goal. theforeman/puppet-katello#303 should reflect that side. One huge motivator for this was also to figure out how we build vhosts. Currently the pulp vhost is used. Given we'll need to do more, I'm leaning to dropping that and explicitly defining a vhost in this module. We already have the reverse proxy on port 8443. That could actually be moved to port 443 as well (though at a later stage). |
| enable_puppet => $enable_puppet, | ||
| enable_rpm => $enable_yum, | ||
| manage_db => $mongodb_manage_db, | ||
| manage_httpd => $is_mirror, |
There was a problem hiding this comment.
I assume $is_mirror has value true for the proxy scenario and false for katello. Can I take the same approach when building the logic for pulp3?
There was a problem hiding this comment.
It is sort of based on Pulp 3 where there's no longer the concept of a master and a node. Just the is_mirror parameter. I've started to like that.
|
Ewoud says NEIN |
This is a WIP PR that moves all Pulp handling to a central class. It integrates the handling that puppet-katello did in the past.
This builds on a bunch of other PRs: