-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #30436 - add import/export params #297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for kicking this off @jeremylenz !
What we also need here is to declare, set a default for, and document the new parameter we are introducing in this module. 1d2eef1 is a nice and recent example of exactly what that looks like.
@wbclark updated |
I think the test failures are because theforeman/puppet-pulpcore#147, which defines the |
2e8bb71
to
af28412
Compare
@ekohl any other concerns? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs to update the dependency on puppet-pulpcore in metadata.json. I intend to do a release of it, but first theforeman/puppet-pulpcore#150 should be merged. IMHO that should have been the implementation in the first place, but it was merged before I could correct it.
I opened theforeman/puppet-pulpcore#151. Please update metadata.json to at least require 2.2.0. |
@ekohl Thanks, updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits.
ca54f7b
to
60a9627
Compare
This is the "second PR" from theforeman/puppet-pulpcore#147 (review)