Fixes #30436 - add allowed_export_paths to settings.py

[jeremylenz]

As part of the new content view import/export API work, we need to be able to add import & export paths to settings.py:

ALLOWED_IMPORT_PATHS = ['/var/lib/pulp/sync_imports', '/var/lib/pulp/imports'] # already exists
ALLOWED_EXPORT_PATHS = ['/var/lib/pulp/exports'] # new

This PR will be modeled on #79 and adds ALLOWED_EXPORT_PATHS.

[wbclark]

Hey @jeremylenz thanks for this PR!

I have a few questions to better understand:

1. Do you consider the change to default $allowed_import_path to fall under the same Redmine? Should it be split into a separate commit, or separate PR and Redmine entirely?

2. Should this configuration be the same for standalone pulp3, pulp3 on katello, and pulp3 on content proxy? This module is used for both the katello and foreman_proxy_content installer scenarios and unless the configuration should be the same in both cases, we should expose the new parameter in puppet-foreman_proxy_content so that the installer can pass different values of the parameter per scenario.

[jeremylenz]

@wbclark good questions!

For item 1 the change is related and small enough that I think it can stay here in this PR and redmine.
Regarding item 2 - It's definitely relevant for pulp3 on katello. I don't think this is relevant for standalone pulp3, but I'm not sure about pulp3 on content proxy. @parthaa can probably give a better answer.

[wbclark]

OK, thinking about it a bit, content proxies shouldn't need CV import/export since they sync directly from Katello

So I think we should make the following changes:

1. This PR should include only the new parameter for $allowed_export_path

2. A second PR should be opened in puppet-FPC which exposes $allowed_{import,export}_path parameters at https://github.com/theforeman/puppet-foreman_proxy_content/blob/master/manifests/init.pp#L371-L394

3. A 3rd PR should be opened in foreman-installer which overrides the default $allowed_{import,export}_path parameters for the Katello scenario only, and also defines a migration for the Katello scenario that sets the proper values of the parameters for users who already installed

[jeremylenz]

@wbclark, Thanks for guiding this newbie 👍

This PR should include only the new parameter for $allowed_export_path

updated

A second PR should be opened in puppet-FPC which exposes $allowed_{import,export}_path parameters at https://github.com/theforeman/puppet-foreman_proxy_content/blob/master/manifests/init.pp#L371-L394

Opened theforeman/puppet-foreman_proxy_content#297

A 3rd PR should be opened in foreman-installer which overrides the default $allowed_{import,export}_path parameters for the Katello scenario only, and also defines a migration for the Katello scenario that sets the proper values of the parameters for users who already installed

Opened theforeman/foreman-installer#615

Let me know how they look..

[wbclark]

Hey @jeremylenz thanks for the effort here! It's coming together nicely.

I left one comment above about setting defaults that make sense for pulp3 on its own.

The other thing I want to mention, following a similar line of reasoning, is the parameter documentation making references to concepts like Katello and Content Views, which pulpcore itself has no concept of. I think having more neutral documentation (see @ekohl 's suggestion referencing the pulpcore docs) makes sense here, while in puppet-FPC we can document the relevance to Katello users.

I also realize I am saying this that some of those references were already here before your PR (in the ERB...) -- sorry that you inherited that and let us know if we can assist with cleaning it up. :)

[jeremylenz]

@wbclark @ehelms @ekohl I tried to address comments on all 3 PR's.. let me know what I missed. thanks!

[jeremylenz]

@wbclark thanks, updated!

[ekohl]

This matches the default. I'd move this to the section that starts at line 19. We should probably do the same for import paths.

[jeremylenz]

@ekohl updated

[ekohl]

Not sure why this was merged. I still had comments about the specs and it was not addressed as I suggested. I also think this should have been squashed and not as 6 separate commits.

[ehelms]

Sorry, it looked like your comment had been resolved. I do wish Github would warn me when there are multiple commits, that was my bad.